Skip to content

Commit 670497a

Browse files
130715: Fixed fallback values not being used when undefined is used explicitly
1 parent db9fa05 commit 670497a

2 files changed

Lines changed: 1 addition & 3 deletions

File tree

scripts/generate-decorator-registries.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ const writeRegistryFile = (
127127
const mapPathsSoFar = new Set<string>();
128128

129129
for (const component of components) {
130-
const argsArray = decoratorConfig.params.map((param, index) => (index < component.args.length && component.args[index] !== undefined) ? component.args[index] : param.default);
130+
const argsArray = decoratorConfig.params.map((param, index) => (index < component.args.length && component.args[index]?.classRef !== 'undefined') ? component.args[index] : param.default);
131131

132132
let currentMapPath = mapVarName;
133133
let currentPathKey = '';

src/app/shared/object-list/listable-notification-object/listable-notification-object.component.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,11 @@ import { ViewMode } from '../../../core/shared/view-mode.model';
55
import { listableObjectComponent } from '../../object-collection/shared/listable-object/listable-object.decorator';
66
import { AbstractListableElementComponent } from '../../object-collection/shared/object-collection-element/abstract-listable-element.component';
77
import { ListableNotificationObject } from './listable-notification-object.model';
8-
import { LISTABLE_NOTIFICATION_OBJECT } from './listable-notification-object.resource-type';
98

109
/**
1110
* The component for displaying a notifications inside an object list
1211
*/
1312
@listableObjectComponent(ListableNotificationObject, ViewMode.ListElement)
14-
@listableObjectComponent(LISTABLE_NOTIFICATION_OBJECT.value, ViewMode.ListElement)
1513
@Component({
1614
selector: 'ds-listable-notification-object',
1715
templateUrl: './listable-notification-object.component.html',

0 commit comments

Comments
 (0)