Skip to content

Commit 9019a67

Browse files
117287: Fixed various layout issues
- The unthemed home news didn't stick to the header like the dspace theme - Impersonate user button has additional margin - Submission form loading icon is not translatable - Create resource policy page doesn't have the correct heading
1 parent 6c1212d commit 9019a67

6 files changed

Lines changed: 8 additions & 10 deletions

File tree

src/app/access-control/epeople-registry/eperson-form/eperson-form.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ <h1 class="border-bottom pb-2">{{messagePrefix + '.create' | translate}}</h1>
3030
</div>
3131
}
3232
@if (canImpersonate$ | async) {
33-
<div between class="btn-group ms-1">
33+
<div between class="btn-group">
3434
@if (!isImpersonated) {
3535
<button class="btn btn-primary" type="button" (click)="impersonate()">
3636
<i class="fa fa-user-secret"></i> {{'admin.access-control.epeople.actions.impersonate' | translate}}

src/app/access-control/epeople-registry/eperson-form/eperson-form.component.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
1-
import {
2-
AsyncPipe,
3-
NgClass,
4-
} from '@angular/common';
1+
import { AsyncPipe } from '@angular/common';
52
import {
63
ChangeDetectorRef,
74
Component,
@@ -84,7 +81,6 @@ import { ValidateEmailNotTaken } from './validators/email-taken.validator';
8481
FormComponent,
8582
AsyncPipe,
8683
TranslateModule,
87-
NgClass,
8884
ThemedLoadingComponent,
8985
PaginationComponent,
9086
RouterLink,

src/app/home-page/home-news/home-news.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<div class="jumbotron py-4 px-2 py-sm-5 px-sm-0 mt-0 mb-4">
1+
<div class="jumbotron py-4 px-2 py-sm-5 px-sm-0 mt-ncs mb-4">
22
<div class="container">
33
<div class="d-flex flex-wrap">
44
<div>

src/app/shared/resource-policies/create/resource-policy-create.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<div class="container">
2-
<h4 class="mb-3">{{'resource-policies.create.page.heading' | translate}} {{targetResourceName}}</h4>
2+
<h1 class="mb-3">{{'resource-policies.create.page.heading' | translate}} {{targetResourceName}}</h1>
33

44
<ds-resource-policy-form [isProcessing]="isProcessing()"
55
(reset)="redirectToAuthorizationsPage()"

src/app/submission/form/submission-form.component.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@
3030
}
3131

3232
<div class="submission-form-content">
33-
@if ((isLoading$ | async)) {
34-
<ds-loading message="Loading..."></ds-loading>
33+
@if (isLoading$ | async) {
34+
<ds-loading [message]="'form.loading' | translate"></ds-loading>
3535
}
3636
@for (object of $any(submissionSections | async); track object) {
3737
<ds-submission-section-container [collectionId]="collectionId"

src/app/submission/form/submission-form.component.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import {
77
OnDestroy,
88
SimpleChanges,
99
} from '@angular/core';
10+
import { TranslatePipe } from '@ngx-translate/core';
1011
import isEqual from 'lodash/isEqual';
1112
import {
1213
Observable,
@@ -64,6 +65,7 @@ import { ThemedSubmissionUploadFilesComponent } from './submission-upload-files/
6465
ThemedSubmissionUploadFilesComponent,
6566
SubmissionFormCollectionComponent,
6667
SubmissionFormSectionAddComponent,
68+
TranslatePipe,
6769
],
6870
standalone: true,
6971
})

0 commit comments

Comments
 (0)