Merge pull request #4837 from atmire/w2p-136225_fix-upstream-private-items-issue-11569-7_x

tdonohue · web-flow · commit c46da88abc58 · 2025-11-19T15:53:18.000-06:00
Add noindex robots meta tag for non-discoverable items (7_x)
diff --git a/src/app/core/metadata/metadata.service.spec.ts b/src/app/core/metadata/metadata.service.spec.ts
@@ -12,7 +12,7 @@ import {
   ItemMock,
   MockBitstream1,
   MockBitstream3,
-  MockBitstream2
+  MockBitstream2, NonDiscoverableItemMock
 } from '../../shared/mocks/item.mock';
 import { createSuccessfulRemoteDataObject, createSuccessfulRemoteDataObject$ } from '../../shared/remote-data.utils';
 import { PaginatedList } from '../data/paginated-list.model';
@@ -119,6 +119,37 @@ describe('MetadataService', () => {
     );
   });
 
+  describe(`robots tag`, () => {
+    it(`should be set to noindex for non-discoverable items`, fakeAsync(() => {
+      (metadataService as any).processRouteChange({
+        data: {
+          value: {
+            dso: createSuccessfulRemoteDataObject(NonDiscoverableItemMock),
+          },
+        },
+      });
+      tick();
+      expect(meta.addTag).toHaveBeenCalledWith({
+        name: 'robots',
+        content: 'noindex',
+      });
+    }));
+    it(`should not be set for discoverable items`, fakeAsync(() => {
+      (metadataService as any).processRouteChange({
+        data: {
+          value: {
+            dso: createSuccessfulRemoteDataObject(ItemMock),
+          },
+        },
+      });
+      tick();
+      expect(meta.addTag).not.toHaveBeenCalledWith({
+        name: 'robots',
+        content: 'noindex',
+      });
+    }));
+  });
+
   it('items page should set meta tags', fakeAsync(() => {
     (metadataService as any).processRouteChange({
       data: {
diff --git a/src/app/core/metadata/metadata.service.ts b/src/app/core/metadata/metadata.service.ts
@@ -148,6 +148,8 @@ export class MetadataService {
 
   private setDSOMetaTags(): void {
 
+    this.setNoIndexTag();
+
     this.setTitleTag();
     this.setDescriptionTag();
 
@@ -185,6 +187,15 @@ export class MetadataService {
 
   }
 
+  /**
+   * Add <meta name="robots" content="noindex">  to the <head> if non-discoverable item
+   */
+  protected setNoIndexTag(): void {
+    if (this.currentObject.value instanceof Item && this.currentObject.value.isDiscoverable === false) {
+      this.addMetaTag('robots', 'noindex');
+    }
+  }
+
   /**
    * Add <meta name="title" ... >  to the <head>
    */
diff --git a/src/app/shared/mocks/item.mock.ts b/src/app/shared/mocks/item.mock.ts
@@ -293,4 +293,55 @@ export const ItemMock: Item = Object.assign(new Item(), {
     }
   )
 });
+
+export const NonDiscoverableItemMock: Item = Object.assign(new Item(), {
+  handle: '10673/7',
+  lastModified: '2017-04-24T19:44:08.178+0000',
+  isArchived: true,
+  isDiscoverable: false,
+  isWithdrawn: false,
+  bundles: createSuccessfulRemoteDataObject$(createPaginatedList([
+    MockOriginalBundle,
+  ])),
+  _links:{
+    self: {
+      href: 'https://dspace7.4science.it/dspace-spring-rest/api/core/items/0ec7ff22-f211-40ab-a69e-c819b0b1f358',
+    },
+  },
+  id: '0ec7ff22-f211-40ab-a69e-c819b0b1f358',
+  uuid: '0ec7ff22-f211-40ab-a69e-c819b0b1f358',
+  type: 'item',
+  metadata: {
+    'dc.date.accessioned': [
+      {
+        language: null,
+        value: '1650-06-26T19:58:25Z',
+      },
+    ],
+    'dc.date.available': [
+      {
+        language: null,
+        value: '1650-06-26T19:58:25Z',
+      },
+    ],
+    'dc.date.issued': [
+      {
+        language: null,
+        value: '1650-06-26',
+      },
+    ],
+    'dc.identifier.uri': [
+      {
+        language: null,
+        value: 'http://dspace7.4science.it/xmlui/handle/10673/7',
+      },
+    ],
+    'dc.title': [
+      {
+        language: 'en_US',
+        value: 'Test Non-Discoverable',
+      },
+    ],
+  },
+});
 /* eslint-enable @typescript-eslint/no-shadow */
