Skip to content

Commit dbd8ae8

Browse files
JohnnyMendesCgithub-actions[bot]
authored andcommitted
fix(#5645): Use correct key value to block Space keypress in BtnDisabledDirective
(cherry picked from commit 95db2d8)
1 parent 446f84f commit dbd8ae8

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

src/app/shared/btn-disabled.directive.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ export class BtnDisabledDirective {
5353
*/
5454
@HostListener('keydown', ['$event'])
5555
handleKeydown(event: KeyboardEvent) {
56-
if (this.isDisabled && (event.key === 'Enter' || event.key === 'Space')) {
56+
if (this.isDisabled && (event.key === 'Enter' || event.key === ' ')) {
5757
event.preventDefault();
5858
event.stopImmediatePropagation();
5959
}

src/app/shared/disabled-directive.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ describe('DisabledDirective', () => {
7878
button.nativeElement.addEventListener('keydown', () => keydownHandled = true);
7979

8080
const enterEvent = new KeyboardEvent('keydown', { key: 'Enter' });
81-
const spaceEvent = new KeyboardEvent('keydown', { key: 'Space' });
81+
const spaceEvent = new KeyboardEvent('keydown', { key: ' ' });
8282

8383
button.nativeElement.dispatchEvent(enterEvent);
8484
button.nativeElement.dispatchEvent(spaceEvent);
@@ -96,7 +96,7 @@ describe('DisabledDirective', () => {
9696
button.nativeElement.click();
9797

9898
const enterEvent = new KeyboardEvent('keydown', { key: 'Enter' });
99-
const spaceEvent = new KeyboardEvent('keydown', { key: 'Space' });
99+
const spaceEvent = new KeyboardEvent('keydown', { key: ' ' });
100100

101101
button.nativeElement.dispatchEvent(enterEvent);
102102
button.nativeElement.dispatchEvent(spaceEvent);

0 commit comments

Comments
 (0)