Skip to content

Commit f1e96b9

Browse files
authored
Merge pull request #5682 from DSpace/backport-5660-to-dspace-8_x
[Port dspace-8_x] fix(#5645): Use correct key value to block Space keypress in BtnDisabled
2 parents e2971c5 + e89c3f2 commit f1e96b9

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

src/app/shared/btn-disabled.directive.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ export class BtnDisabledDirective {
5454
*/
5555
@HostListener('keydown', ['$event'])
5656
handleKeydown(event: KeyboardEvent) {
57-
if (this.isDisabled && (event.key === 'Enter' || event.key === 'Space')) {
57+
if (this.isDisabled && (event.key === 'Enter' || event.key === ' ')) {
5858
event.preventDefault();
5959
event.stopImmediatePropagation();
6060
}

src/app/shared/disabled-directive.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ describe('DisabledDirective', () => {
7676
button.nativeElement.addEventListener('keydown', () => keydownHandled = true);
7777

7878
const enterEvent = new KeyboardEvent('keydown', { key: 'Enter' });
79-
const spaceEvent = new KeyboardEvent('keydown', { key: 'Space' });
79+
const spaceEvent = new KeyboardEvent('keydown', { key: ' ' });
8080

8181
button.nativeElement.dispatchEvent(enterEvent);
8282
button.nativeElement.dispatchEvent(spaceEvent);
@@ -94,7 +94,7 @@ describe('DisabledDirective', () => {
9494
button.nativeElement.click();
9595

9696
const enterEvent = new KeyboardEvent('keydown', { key: 'Enter' });
97-
const spaceEvent = new KeyboardEvent('keydown', { key: 'Space' });
97+
const spaceEvent = new KeyboardEvent('keydown', { key: ' ' });
9898

9999
button.nativeElement.dispatchEvent(enterEvent);
100100
button.nativeElement.dispatchEvent(spaceEvent);

0 commit comments

Comments
 (0)