NG2011 compile error: non-standalone components in imports array (dspace theme)

[RenteriaMX]

Describe the bug

In branch dspace-9_x, the file src/themes/dspace/eager-theme.module.ts
spreads DECLARATIONS into the imports array of the @NgModule decorator.
These components are not standalone, causing Angular NG2011 compile errors
that prevent the application from building.

Affected components:

• HeaderComponent
• HeaderNavbarWrapperComponent
• HomeNewsComponent
• NavbarComponent

DSpace version: 9.x (dspace-angular 9.3.0-next)

To Reproduce

1. Clone the repo and checkout branch dspace-9_x
2. Run npm run start:dev
3. Build fails with NG2011 errors

Expected behavior

The app should compile successfully. The DECLARATIONS array should be in
declarations: [...DECLARATIONS], not in imports: [...DECLARATIONS].

Related work

Fix: move ...DECLARATIONS from imports to declarations in the
@NgModule decorator in src/themes/dspace/eager-theme.module.ts

[lgeggleston]

Hi @RenteriaMX! Thank you for noting this. However, I'm going to close this out for two reasons:

1. I was not able to reproduce the build errors via building the latest 9_x branch locally, and the Demo site running 9.x also does not appear to have had issues.
2. This theme module file has been changed in 10.0, making the suggested changes not applicable to the latest version - here are docs for what that upgrade will look like for 10.

I would recommend checking if your versions of Angular and npm are compatible or if you have any custom code that might affect this. However, if you can provide more details about your setup that allow us to reproduce the error, we can reopen - or you're welcome to put up a PR and open it to testing.