Missing delete button for repeatable field with value pairs

[VictorDuranEscire]

Hi @tdonohue, I'm @jtimal partner. We have been working on this issue and we will send you the PR.

References

• Fixes DSpace 7: Missing delete button for repeatable field with value pairs #2568

Description

Added a validation to show the delete button on repeatable fields only if a value is selected or a new value is added.

Instructions for Reviewers

Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.

List of changes in this PR:

• Validation for show delete button for repeatable field with value pairs
• Validation to insert a new item only if delete the last item in the repeatable field

To validate:

1. Select a value for a repeatable field with value pairs. E.g. "article" for dc.type
2. Verify the delete buttons appears when your add a value on input

Checklist

• My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using npm run lint
• My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• My PR aligns with Accessibility guidelines if it makes changes to the user interface.
• My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
• My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[tdonohue]

Closing as this already appears to be fixed. There's a "Clear Selection" option in all value pairs dropdowns, which makes the delete button unnecessary. This can be seen on demo.dspace.org (running 8.1)