Fix - previously entered qualdrop value field is deleted when adding a new (emtpy) line with the same(!) qualifier and then deleting it

[VictorDuranEscire]

Hi @tdonohue, I'm @jtimal partner. We have been working on this issue and we will send you the PR.

References

• Fixes DSpace 7: previously entered qualdrop value field is deleted when adding a new (emtpy) line with the same(!) qualifier and then deleting it #2567

Description

Validate value on remove item for submission form only for qualdrop component

List of changes in this PR:

• I added a validation for the model value of the qualdrop component to not emit the delete event if it didn't have a previous value

Instructions for Reviewers

To reproduce

1. Enter a value for a qualdrop_value field (e.g. dc.identifier.issn)
2. Use the plus button to add another line. Select the same qualifier as above.
3. Leave the newly added line empty (do not enter a value) and click on the delete button
4. Save your item

Checklist

• My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using npm run lint
• My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• [] My PR aligns with Accessibility guidelines if it makes changes to the user interface.
• My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
• My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[tdonohue]

👍 Thanks @VictorDuranEscire ! I finally got around to testing this today, and this PR resolves the bug. I can no longer reproduce it.

[dspace-bot]

Successfully created backport PR for dspace-7_x:

• [Port dspace-7_x] Fix - previously entered qualdrop value field is deleted when adding a new (emtpy) line with the same(!) qualifier and then deleting it  #4238

[dspace-bot]

Successfully created backport PR for dspace-8_x:

• [Port dspace-8_x] Fix - previously entered qualdrop value field is deleted when adding a new (emtpy) line with the same(!) qualifier and then deleting it  #4239