Skip to content

Restored breadcrumbs on collection pages#4061

Merged
tdonohue merged 1 commit intoDSpace:mainfrom
alexandrevryghem:restored-breadcrumbs-on-collection-pages_contribute-main
Mar 10, 2025
Merged

Restored breadcrumbs on collection pages#4061
tdonohue merged 1 commit intoDSpace:mainfrom
alexandrevryghem:restored-breadcrumbs-on-collection-pages_contribute-main

Conversation

@alexandrevryghem
Copy link
Copy Markdown
Member

References

Description

Currently the breadcrumbs are not showing on collection pages on the latest version of main. This seems to have been done by mistake so I have reverted that change.

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@alexandrevryghem alexandrevryghem added bug quick win Pull request is small in size & should be easy to review and/or merge component: Collection Collection display or editing labels Mar 9, 2025
@alexandrevryghem alexandrevryghem added this to the 9.0 milestone Mar 9, 2025
@alexandrevryghem alexandrevryghem self-assigned this Mar 9, 2025
@alexandrevryghem alexandrevryghem moved this to 🙋 Needs Reviewers Assigned in DSpace 9.0 Release Mar 10, 2025
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @alexandrevryghem ! I've verified this is happening on sandbox.dspace.org as well. This fix looks correct.

(Also verified this does NOT happen on demo.dspace.org which is running 8.x. So, it seems to be specific to the main branch)

@github-project-automation github-project-automation Bot moved this from 🙋 Needs Reviewers Assigned to 👍 Reviewer Approved in DSpace 9.0 Release Mar 10, 2025
@tdonohue tdonohue merged commit aca1411 into DSpace:main Mar 10, 2025
15 checks passed
@github-project-automation github-project-automation Bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 9.0 Release Mar 10, 2025
@alexandrevryghem alexandrevryghem deleted the restored-breadcrumbs-on-collection-pages_contribute-main branch March 10, 2025 14:21
4science-it pushed a commit to 4Science/dspace-angular that referenced this pull request Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug component: Collection Collection display or editing quick win Pull request is small in size & should be easy to review and/or merge

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants