Skip to content

add dhivehi language files#4096

Closed
siyamex wants to merge 2 commits intoDSpace:mainfrom
siyamex:main
Closed

add dhivehi language files#4096
siyamex wants to merge 2 commits intoDSpace:mainfrom
siyamex:main

Conversation

@siyamex
Copy link
Copy Markdown

@siyamex siyamex commented Mar 19, 2025

Dhivehi translate files added

Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siyamex : Thanks for this contribution! Just as a note, this appears to currently be failing our build process because the npm run lint command is throwing errors that say your dv.json5 file is incorrectly formatted.

I believe I've found the issue below (see my inline comment)

Comment thread src/assets/i18n/dv.json5
"cookies.consent.purpose.functional": "ފަންކްޝަނަލް",
"cookies.consent.purpose.statistical": "ސްޓެޓިސްޓިކަލް",
"cookies.consent.purpose.registration-password-recovery": "ރެޖިސްޓްރޭޝަންކުރުމާއި ޕާސްވޯރޑް ރިކަވަރީކުރުން",
"cookies.consent.purpose.sharing": "ހިއްސާކުރަނީ"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is missing the trailing comma (,). If you add a comma to the end of this line, that should fix the formatting errors.

@tdonohue tdonohue added i18n / l10n Internationalisation and localisation, related to message catalogs 1 APPROVAL pull request only requires a single approval to merge labels Mar 24, 2025
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 9.0 Release Mar 24, 2025
@tdonohue tdonohue moved this to 👀 Under Review in DSpace 10.0 Release May 19, 2025
@github-actions
Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had
activity in one year. It will be closed in 14 days if no further activity occurs.

Allowing pull requests to close as stale helps us filter out old work that is no longer
relevant and helps developers focus on reviewing current work.

All pull requests closed by this bot act like normal pull requests;
they can be searched for, commented on or reopened at any point.

If these changes are still relevant then please comment and/or rebase your PR based on the
latest DSpace code. This will remove the stale status and notify us to assign a reviewer
for your PR.

@github-actions github-actions bot added the stale This issue or PR is stale because it has not been updated in a long time. label Mar 29, 2026
@github-actions
Copy link
Copy Markdown

This pull request has been closed automatically. If these changes are still relevant
then please re-open this pull request with a comment and rebase your PR based on the latest
DSpace code. This will notify us to assign a reviewer to your PR.

@github-actions github-actions bot closed this Apr 12, 2026
@github-project-automation github-project-automation bot moved this from 👀 Under Review to ✅ Done in DSpace 10.0 Release Apr 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge i18n / l10n Internationalisation and localisation, related to message catalogs stale This issue or PR is stale because it has not been updated in a long time.

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants