Skip to content

Fix unable to remove data from a submission form field of type "name" #4167

Merged
tdonohue merged 1 commit intoDSpace:dspace-8_xfrom
atmire:w2p-129621_submission-form-field-type-name-null-issue_contribute-8.1
Apr 23, 2025
Merged

Fix unable to remove data from a submission form field of type "name" #4167
tdonohue merged 1 commit intoDSpace:dspace-8_xfrom
atmire:w2p-129621_submission-form-field-type-name-null-issue_contribute-8.1

Conversation

@AbhinavS96
Copy link
Copy Markdown
Contributor

Description

Adding a null check similar to the other handlers in the file. Fixes #4073

Instructions for Reviewers

List of changes in this PR:

  • Additional null check in dispatchOperationsFromChangeEvent

This can be tested on a submission form that has an input of type "name". As mentioned in the issue, the "editor" field of the journal submission form is a good candidate to test this.

  1. Type something in the "editor" field.
  2. Save the form
  3. Remove the text from the same field
  4. Save the form
  5. Refresh the page

The field should now be empty.

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

This check is present in the other event handlers above so adding it here as well.
@tdonohue tdonohue added bug high priority 1 APPROVAL pull request only requires a single approval to merge port to main This PR needs to be ported to `main` branch for the next major release port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release and removed port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release labels Apr 22, 2025
@tdonohue tdonohue self-requested a review April 23, 2025 15:28
@tdonohue tdonohue moved this to 👀 Under Review in DSpace 9.0 Release Apr 23, 2025
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @AbhinavS96 ! I've verified this fixes the reported bug. I've also verified this bug seems to affect 7.x and main as well. So, this PR should be ported to those releases (hopefully the automatic ports should work for this small PR).

@github-project-automation github-project-automation bot moved this from 👀 Under Review to 👍 Reviewer Approved in DSpace 9.0 Release Apr 23, 2025
@tdonohue tdonohue merged commit e9a3272 into DSpace:dspace-8_x Apr 23, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 9.0 Release Apr 23, 2025
@dspace-bot
Copy link
Copy Markdown
Contributor

@dspace-bot
Copy link
Copy Markdown
Contributor

Successfully created backport PR for dspace-7_x:

@tdonohue tdonohue added this to the 8.2 milestone Apr 23, 2025
@tdonohue tdonohue removed port to main This PR needs to be ported to `main` branch for the next major release port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release labels Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug high priority

Projects

Development

Successfully merging this pull request may close these issues.

3 participants