Fix unable to remove data from a submission form field of type "name" #4167
Merged
tdonohue merged 1 commit intoDSpace:dspace-8_xfrom Apr 23, 2025
Conversation
This check is present in the other event handlers above so adding it here as well.
tdonohue
approved these changes
Apr 23, 2025
Member
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @AbhinavS96 ! I've verified this fixes the reported bug. I've also verified this bug seems to affect 7.x and main as well. So, this PR should be ported to those releases (hopefully the automatic ports should work for this small PR).
Contributor
|
Successfully created backport PR for |
Contributor
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding a null check similar to the other handlers in the file. Fixes #4073
Instructions for Reviewers
List of changes in this PR:
This can be tested on a submission form that has an input of type "name". As mentioned in the issue, the "editor" field of the journal submission form is a good candidate to test this.
The field should now be empty.
Checklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.