Skip to content

Fix export button enabled in bulk access management without selecting step 2#4168

Merged
tdonohue merged 1 commit intoDSpace:mainfrom
atmire:fix-export-button_contribute-main
Apr 11, 2025
Merged

Fix export button enabled in bulk access management without selecting step 2#4168
tdonohue merged 1 commit intoDSpace:mainfrom
atmire:fix-export-button_contribute-main

Conversation

@AbhinavS96
Copy link
Copy Markdown
Contributor

@AbhinavS96 AbhinavS96 commented Apr 11, 2025

References

Description

The export button in Bulk Access Management was not considering the state of step 2 in the form. This has been fixed.

Instructions for Reviewers

List of changes in this PR:

  • Export button in Bulk Access Management has an extra check in canExport now.
  • Tests for the component are modified. This includes tests for the new case and some refactoring to handle the dynamically loaded components.

This can be tested by logging in as Admin and navigating to Bulk Access Management. The button should activate only when there is some selection in both steps.

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@alexandrevryghem alexandrevryghem moved this to 🙋 Needs Reviewers Assigned in DSpace 9.0 Release Apr 11, 2025
@alexandrevryghem alexandrevryghem added this to the 9.0 milestone Apr 11, 2025
@alexandrevryghem alexandrevryghem added the port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release label Apr 11, 2025
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @AbhinavS96 ! I was able to reproduce the bug locally, and I've verified this PR fixes it by disabling the "Execute" button until you've completed both sections.

@github-project-automation github-project-automation bot moved this from 🙋 Needs Reviewers Assigned to 👍 Reviewer Approved in DSpace 9.0 Release Apr 11, 2025
@tdonohue tdonohue merged commit 5e5c2ab into DSpace:main Apr 11, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 9.0 Release Apr 11, 2025
@dspace-bot
Copy link
Copy Markdown
Contributor

@tdonohue tdonohue removed the port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release label May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug component: administrative tools Related to the admin menu or tools usability

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Bulk Access Management processes are executable without selecting any options in step 2

4 participants