[Port dspace-7_x] Clean up spacing in input forms#4180
Merged
tdonohue merged 1 commit intoDSpace:dspace-7_xfrom Sep 10, 2025
Merged
[Port dspace-7_x] Clean up spacing in input forms#4180tdonohue merged 1 commit intoDSpace:dspace-7_xfrom
tdonohue merged 1 commit intoDSpace:dspace-7_xfrom
Conversation
alanorth
force-pushed
the
port-4136-dspace-7
branch
from
3ed76d2 to
90981c8
Compare
Manual port of DSpace#4136 by @gingyx to DSpace 7.x.
alanorth
force-pushed
the
port-4136-dspace-7
branch
from
90981c8 to
377c703
Compare
alexandrevryghem
requested review from
alexandrevryghem
and removed request for
gingyx
tdonohue
moved this to 🙋 Needs Reviewers Assigned
in DSpace Maintenance (9.x, 8.x, 7.6.x)
github-project-automation
bot
moved this from 🙋 Needs Reviewers Assigned
to 👍 Reviewer Approved
in DSpace Maintenance (9.x, 8.x, 7.6.x)
tdonohue
approved these changes
Sep 10, 2025
Member
tdonohue
left a comment
tdonohue
left a comment
There was a problem hiding this comment.
Thanks as well @alanorth ! The code changes look the same to me. I'll flag this as port to dspace-8_x as well so that we hopefully can also get this change synced to that branch (since it's already on 9.x, main and now 7.x in this PR)
tdonohue
added
the
port to dspace-8_x
tdonohue
added
the
1 APPROVAL
github-project-automation
bot
moved this from 👍 Reviewer Approved
to ✅ Done
in DSpace Maintenance (9.x, 8.x, 7.6.x)
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin dspace-8_x
git worktree add -d .worktree/backport-4180-to-dspace-8_x origin/dspace-8_x
cd .worktree/backport-4180-to-dspace-8_x
git switch --create backport-4180-to-dspace-8_x
git cherry-pick -x 377c7034ffe880fb32be9a8dfa2351a310f3050f |
This was referenced Sep 10, 2025
tdonohue
removed
the
port to dspace-8_x
Member
|
Ported to 8.x in #4713 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual port of #4136 by @gingyx to DSpace 7.x.
I think this is a faithful port of the original PR. DSpace 9 switched to Angular Control Flow syntax so the patch had to be adapted to use the old
ngIfsyntax. Below on my DSpace 7.6.3 instance (don't mind the green branding of my theme, the functionality is the same).Before
After
The elements for each input are grouped together more coherently and the error text is aligned the same as the hint.