Skip to content

Fix: adding tooltips to indicate functionality of buttons when switching views of search results#4193

Merged
tdonohue merged 1 commit intoDSpace:mainfrom
jesielviana:add-tooltips-to-switch-view-buttons
Apr 15, 2025
Merged

Fix: adding tooltips to indicate functionality of buttons when switching views of search results#4193
tdonohue merged 1 commit intoDSpace:mainfrom
jesielviana:add-tooltips-to-switch-view-buttons

Conversation

@jesielviana
Copy link
Copy Markdown
Contributor

References

Description

Added tooltips to the view mode switch buttons in the search results to indicate their functionality.

Instructions for Reviewers

This PR enhances the user experience by providing tooltips on buttons that switch between different view modes in the search results.
tooltip

List of changes in this PR:

  • Updated the view-mode-switch.component.html file.
  • Added title attributes to each view switch button to display tooltips on hover.

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added usability 1 APPROVAL pull request only requires a single approval to merge testathon Reported by a tester during Community Testathon labels Apr 15, 2025
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 9.0 Release Apr 15, 2025
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @jesielviana ! I gave this a test and review today and it fixes the usability issue.

@github-project-automation github-project-automation Bot moved this from 🙋 Needs Reviewers Assigned to 👍 Reviewer Approved in DSpace 9.0 Release Apr 15, 2025
@tdonohue tdonohue added this to the 9.0 milestone Apr 15, 2025
@tdonohue tdonohue merged commit 67c2b33 into DSpace:main Apr 15, 2025
15 checks passed
@github-project-automation github-project-automation Bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 9.0 Release Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge testathon Reported by a tester during Community Testathon usability

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Adding tooltips to indicate functionality of buttons when switching views of search results

2 participants