Fix accessibility issues with placeholder text in submission forms by removing placeholders

[FrancescoMolinaro]

References

Fixes #4198

Description

Following what is described in https://www.deque.com/blog/accessible-forms-the-problem-with-placeholders/ as an issue with placeholder, this PR removes all placeholders on submission form fields (replacing them with labels where needed)

Instructions for Reviewers

Placeholders should no longer exist on any fields within the submission form. The Series/Report No. field now has sublabels.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

• My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using npm run lint
• My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• My PR aligns with Accessibility guidelines if it makes changes to the user interface.
• My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
• My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[tdonohue]

Temporarily closing & reopening this PR to trigger tests to run again. The e2e test failures currently in this PR seem unrelated to the PR itself, and I'm hoping reopening this PR will get this to run against latest main.

[tdonohue]

@FrancescoMolinaro : Just a note this PR seems to be failing the automated accessibility scan that is done in e2e tests. The failure is in the Submission Form and it says this:

1 accessibility violation was detected
[
  {
    id: 'label',
    impact: 'critical',
    description: 'Ensure every form element has a label',
    helpUrl: 'https://dequeuniversity.com/rules/axe/4.10/label?application=axeAPI',
    nodes: 4,
    html: [
      '<input class="form-control ng-untouched ng-pristine ng-valid ng-star-inserted" autocomplete="on" id="6_array-0-dc_contributor_author" name="dc.contributor.author" placeholder="" spellcheck="true" tabindex="0" type="text">',
      '<input class="form-control ng-untouched ng-pristine ng-valid ng-star-inserted" autocomplete="on" id="9_array-0-dc_title_alternative" name="dc.title.alternative" placeholder="" spellcheck="true" tabindex="0" type="text">',
      '<input class="form-control ds-form-input-value ng-untouched ng-pristine ng-valid ng-star-inserted" autocomplete="on" id="15_array-0-dc_identifier_QUALDROP_VALUE" name="dc.identifier_QUALDROP_VALUE" placeholder="" spellcheck="false" tabindex="0" type="text">',
      '<input _ngcontent-dspace-angular-c4223387587="" class="form-control scrollable-dropdown-input" id="17_array-0-dc_type" name="dc.type" readonly="" type="text" aria-controls="combobox_17_array-0-dc_type_listbox" autocomplete="off">'
    ]
  }
]
    (Attempt 1 of 3) should create a new submission when using /submit path & pass accessibility

[github-actions]

Hi @FrancescoMolinaro,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

[FrancescoMolinaro]

Hi @tdonohue , sorry for the delay on this one, I have adapted the code to handle also the native components from the form library, the PR should be ready now.

[tdonohue]

👍 Thanks @FrancescoMolinaro ! I retested this today and, as expected, I see that all placeholder text is now removed from the submission form. I didn't notice any side effects to that change. I also feel this is the easiest way to fix the ongoing issues with accessibility of placeholder text.

NOTE: Unfortunately, this won't be possible to backport until #4777 is backported (as that related fix hasn't been backported yet).

[github-actions]

Hi @FrancescoMolinaro,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

[github-actions]

Hi @FrancescoMolinaro,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

[github-actions]

Hi @FrancescoMolinaro,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

[tdonohue]

👍 Thanks @FrancescoMolinaro ! I retested this today and it's looking good. Since #4777 was backported to 9.x and 8.x, I'd like to also backport these accessibility fixes to dspace-9_x and dspace-8_x branches as well.

Merging with one approval & flagging for auto-backport

[dspace-bot]

Backport failed for dspace-8_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-8_x
git worktree add -d .worktree/backport-4199-to-dspace-8_x origin/dspace-8_x
cd .worktree/backport-4199-to-dspace-8_x
git switch --create backport-4199-to-dspace-8_x
git cherry-pick -x 8a2aa4641777be5a22b4b967a043c282b7d1ff49 800a9b5a281572e2a8c0de8753d6f1b67b48ad53 4bf7bedf96d07bed89243b0e0b1a14568f5dbdf4 ef8590f28bdd78cb7158405a0cc35feed9bc8c90 4139d3574271d6c58957002f587d2dc8792a43c3 e560bb485b84c868addd529b38e8182be6a94e13 044da75b001212291e5dffeae9350a307d818ce9 68dd890324dba7efd0e60edfa390673dd61e6189 4680a001b52b54bd4dfddd1f1187e32e5ccb52ae a448157eefaaa0e7fcadf134254e1c4e40a709ba

[dspace-bot]

Backport failed for dspace-9_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-9_x
git worktree add -d .worktree/backport-4199-to-dspace-9_x origin/dspace-9_x
cd .worktree/backport-4199-to-dspace-9_x
git switch --create backport-4199-to-dspace-9_x
git cherry-pick -x 8a2aa4641777be5a22b4b967a043c282b7d1ff49 800a9b5a281572e2a8c0de8753d6f1b67b48ad53 4bf7bedf96d07bed89243b0e0b1a14568f5dbdf4 ef8590f28bdd78cb7158405a0cc35feed9bc8c90 4139d3574271d6c58957002f587d2dc8792a43c3 e560bb485b84c868addd529b38e8182be6a94e13 044da75b001212291e5dffeae9350a307d818ce9 68dd890324dba7efd0e60edfa390673dd61e6189 4680a001b52b54bd4dfddd1f1187e32e5ccb52ae a448157eefaaa0e7fcadf134254e1c4e40a709ba

[tdonohue]

@FrancescoMolinaro : This was unable to be auto-backported to dspace-9_x or dspace-8_x. If you have time, I'd like to get this minimally backported to 9.x, as that's our current supported release. Thanks!

[FrancescoMolinaro]

Hi @tdonohue , I have manually ported to both 9 and 8, you can find the PRs at the following links:

8 - #5445
9 -#5447