fix untyped item display in edit item modal

[artlowel]

References

• Fixes Image Placeholder Overlaps Text in Edit Item Search Modal #4194

Description

Untyped items weren't rendered using the correct listableObjectComponent in the edit modal. The reason seemed to be because of the decorators for untyped items had the wrong context in publication-sidebar-search-list-element.component.ts. They used the context of the scope select which has to be a mistake because the scope select only shows communities and collections. Changing them to the context publications use fixed the issue.

Instructions for Reviewers

Verify that untyped items are rendered identically to items in the admin sidebar → edit → item modal

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

• My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using npm run lint
• My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• My PR aligns with Accessibility guidelines if it makes changes to the user interface.
• My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
• My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[tdonohue]

👍 Thanks @artlowel ! I verified this fixes the bug. Also verified this bug doesn't exist in 8.x (by testing on demo site).