[Port to dspace-8_x] Fix for double view events when using dynamic themes#4232
Merged
tdonohue merged 4 commits intoDSpace:dspace-8_xfrom Apr 23, 2025
Merged
Conversation
tdonohue
added
themes
1 APPROVAL
tdonohue
moved this to 🙋 Needs Reviewers Assigned
in DSpace Maintenance (9.x, 8.x, 7.6.x)
github-project-automation
Bot
moved this from 🙋 Needs Reviewers Assigned
to 👍 Reviewer Approved
in DSpace Maintenance (9.x, 8.x, 7.6.x)
github-project-automation
Bot
moved this from 👍 Reviewer Approved
to ✅ Done
in DSpace Maintenance (9.x, 8.x, 7.6.x)
4science-it
pushed a commit
to 4Science/dspace-angular
that referenced
this pull request
Mar 24, 2026
[DSC-2716] show markdown info panel in cms metadata edit Approved-by: Francesco Molinaro
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
This PR moves the tracking of view events for the purpose of registering statistics from a component to a resolver.
This resolves the mentioned issue that whenever a component is pre-rendered before the page is able to load the dynamic theme and load the final version of this component, the view event won't be triggered twice.
Instructions for Reviewers
Add the following to your configuration
Load an item page for an item in the 10673/1161 community while your Network DevTools tab is opened. This should only trigger a single "viewevents" call to the backend once this PR is applied.