Skip to content

[Port to dspace-8_x] Fix for double view events when using dynamic themes #4232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tdonohue merged 4 commits into from
Apr 23, 2025

129694: fixed lint issues

eefc502
Select commit
Loading
Failed to load commit list.
Merged

[Port to dspace-8_x] Fix for double view events when using dynamic themes #4232

129694: fixed lint issues
eefc502
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Apr 23, 2025 in 1s

5.88% of diff hit (target 76.49%)

View this Pull Request on Codecov

5.88% of diff hit (target 76.49%)

Annotations

Check warning on line 28 in src/app/statistics/angulartics/dspace/view-tracker-resolver.service.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/app/statistics/angulartics/dspace/view-tracker-resolver.service.ts#L26-L28 

Added lines #L26 - L28 were not covered by tests

Check warning on line 35 in src/app/statistics/angulartics/dspace/view-tracker-resolver.service.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/app/statistics/angulartics/dspace/view-tracker-resolver.service.ts#L34-L35 

Added lines #L34 - L35 were not covered by tests

Check warning on line 38 in src/app/statistics/angulartics/dspace/view-tracker-resolver.service.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/app/statistics/angulartics/dspace/view-tracker-resolver.service.ts#L38 

Added line #L38 was not covered by tests

Check warning on line 40 in src/app/statistics/angulartics/dspace/view-tracker-resolver.service.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/app/statistics/angulartics/dspace/view-tracker-resolver.service.ts#L40 

Added line #L40 was not covered by tests

Check warning on line 48 in src/app/statistics/angulartics/dspace/view-tracker-resolver.service.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/app/statistics/angulartics/dspace/view-tracker-resolver.service.ts#L48 

Added line #L48 was not covered by tests

Check warning on line 53 in src/app/statistics/angulartics/dspace/view-tracker-resolver.service.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/app/statistics/angulartics/dspace/view-tracker-resolver.service.ts#L52-L53 

Added lines #L52 - L53 were not covered by tests

Check warning on line 55 in src/app/statistics/angulartics/dspace/view-tracker-resolver.service.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/app/statistics/angulartics/dspace/view-tracker-resolver.service.ts#L55 

Added line #L55 was not covered by tests

Check warning on line 57 in src/app/statistics/angulartics/dspace/view-tracker-resolver.service.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/app/statistics/angulartics/dspace/view-tracker-resolver.service.ts#L57 

Added line #L57 was not covered by tests

Check warning on line 59 in src/app/statistics/angulartics/dspace/view-tracker-resolver.service.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/app/statistics/angulartics/dspace/view-tracker-resolver.service.ts#L59 

Added line #L59 was not covered by tests

Check warning on line 62 in src/app/statistics/angulartics/dspace/view-tracker-resolver.service.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/app/statistics/angulartics/dspace/view-tracker-resolver.service.ts#L62 

Added line #L62 was not covered by tests
View more details on Codecov