Skip to content

Fix the last update to the Czech Translation#4242

Merged
tdonohue merged 1 commit intoDSpace:mainfrom
dataquest-dev:cs-translation-thumbnail-more-accurate
Apr 24, 2025
Merged

Fix the last update to the Czech Translation#4242
tdonohue merged 1 commit intoDSpace:mainfrom
dataquest-dev:cs-translation-thumbnail-more-accurate

Conversation

@milanmajchrak
Copy link
Copy Markdown
Contributor

References

#4219

Description

The Czech translation was updated by michdyk here: https://github.com/DSpace/dspace-angular/pull/4219/files#diff-2adb7da35ea504568231fb86fa719a689e0df38dc0205425cddc23a1ef47f2e7, but the changes are not accurate or consistent across all thumbnail-related translations. We suggest reverting the last update, as the previous translation was more accurate and consistent.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added i18n / l10n Internationalisation and localisation, related to message catalogs 1 APPROVAL pull request only requires a single approval to merge labels Apr 24, 2025
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 9.0 Release Apr 24, 2025
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @milanmajchrak for your feedback. Since this is simply reverting changes, I'll merge this immediately

@github-project-automation github-project-automation Bot moved this from 🙋 Needs Reviewers Assigned to 👍 Reviewer Approved in DSpace 9.0 Release Apr 24, 2025
@tdonohue tdonohue added this to the 9.0 milestone Apr 24, 2025
@tdonohue tdonohue merged commit 818f60b into DSpace:main Apr 24, 2025
15 checks passed
@github-project-automation github-project-automation Bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 9.0 Release Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge i18n / l10n Internationalisation and localisation, related to message catalogs

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants