Adjust imports in scripts and webpack directories

[alanorth]

Related

• Use several modern Node.js patterns #4632

Description

A handful of import- and console.log-related fixes were missed in the scripts and webpack directories due to the lint configuration in angular.json not considering them.

Instructions for Reviewers

Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.

List of changes in this PR:

• First, update lint configuration in angular.json to consider scripts and webpack directories
• Second, run npm run lint-fix to automatically fix as many errors as possible
• Third, add node: prefix to several imports of internal Node.js APIs (fs and path) and scope to methods we use
• Fourth, disable eslint for copy-webpack-plugin because it doesn't support ES Module imports
• Fifth, remove unused sass and lodash imports
• Sixth, rework JSON5, commander, and cli-progress imports to use scoped ES Module imports
• Seventh, use scoped imports for lodash modules
• Eighth, replace console.log() usage with console.info()

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Make sure the dev and prod builds are successful.

Make sure i18n scripts work:

$ npm run merge-i18n -- -s src/themes/custom/assets/i18n
$ npm run sync-i18n

Make sure all tests in CI pass.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

• My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using npm run lint
• My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• My PR aligns with Accessibility guidelines if it makes changes to the user interface.
• My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
• My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[github-actions]

Hi @alanorth,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

[nwoodward]

@alanorth I'm sorry I didn't look at this sooner. It's mainly formatting and prefixes. Can you fix the conflicts and I'll review it?

[alexandrevryghem]

Thnx @alanorth for this PR! I already took a quick look at the changed files and it looks great. I did add one small inline suggestion, but I will do a full review once those conflicts are resolved

[alanorth]

The scope of this PR has changed because main updated the linting rules. Now there are more things to fix in the scripts and webpack directories. I am working on it.

[alanorth]

I'm not sure why the lodash import rule is triggering, since we are importing individual methods:

import {
  isEmpty,
  isEqual,
} from 'lodash';

Must be something subtle about the plugin's configuration? @alexandrevryghem?

[alexandrevryghem]

@alanorth: It's part of the lodash/import-scope rule. The correct usage is:

import isEmpty from 'lodash/isEmpty';
import isEqual from 'lodash/isEqual';

[alanorth]

Thanks @alexandrevryghem. I've updated it.

For what it's worth, I see our configuration of lodash/import-scope uses the "method" import style:

import isEmpty from 'lodash/isEmpty';
import isEqual from 'lodash/isEqual';

While this style would be the "member" style:

import {
  isEmpty,
  isEqual,
} from 'lodash';

All of our other imports in dspace-angular use the latter style.

P.S. removing the port to dspace-9_x tag since this ended up being more changes than I thought (and for example, the console.log() linting changes were not ported there).