Skip to content

[Port dspace-8_x] Use node:crypto instead of third-party md5#5413

Merged
tdonohue merged 1 commit intoDSpace:dspace-8_xfrom
alanorth:use-node-md5-8x
Apr 7, 2026
Merged

[Port dspace-8_x] Use node:crypto instead of third-party md5#5413
tdonohue merged 1 commit intoDSpace:dspace-8_xfrom
alanorth:use-node-md5-8x

Conversation

@alanorth
Copy link
Copy Markdown
Contributor

@alanorth alanorth commented Apr 7, 2026

Manual port of #5404 to dspace-8_x.

Note: this differs slightly from #5404 in that the external md5 dependency was never declared in package.json. Ironically, it was me who discovered that and added the md5 dependency in #4762 for main a few months ago! 😆

As this is a very simple PR, I will tag it for automatic porting to dspace-7_x.

Use Node.js native Crypto to calculate md5 hashes instead of third-
party md5 library.
@alanorth alanorth added dependencies Pull requests that update a dependency file 1 APPROVAL pull request only requires a single approval to merge port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release labels Apr 7, 2026
@alanorth alanorth changed the base branch from main to dspace-8_x April 7, 2026 16:42
@tdonohue tdonohue added this to the 8.4 milestone Apr 7, 2026
@alanorth
Copy link
Copy Markdown
Contributor Author

alanorth commented Apr 7, 2026

Closing and re-opening this, as I accidentally opened it against main and then switched the base branch to dspace-8_x and it seems to have interrupted the tests in CI.

@alanorth alanorth closed this Apr 7, 2026
@alanorth alanorth reopened this Apr 7, 2026
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @alanorth ! Looks good to me & looks like an accurate backport

@github-project-automation github-project-automation Bot moved this to 👍 Reviewer Approved in DSpace Maintenance (9.x, 8.x, 7.6.x) Apr 7, 2026
@tdonohue tdonohue merged commit d3ef8b0 into DSpace:dspace-8_x Apr 7, 2026
17 checks passed
@github-project-automation github-project-automation Bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace Maintenance (9.x, 8.x, 7.6.x) Apr 7, 2026
@dspace-bot
Copy link
Copy Markdown
Contributor

Successfully created backport PR for dspace-7_x:

@tdonohue tdonohue removed the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge dependencies Pull requests that update a dependency file

Projects

Development

Successfully merging this pull request may close these issues.

3 participants