Skip to content

[Port dspace-9_x] Fix accessibility issues with placeholder text in submission forms by removing placeholders#5447

Merged
tdonohue merged 10 commits intoDSpace:dspace-9_xfrom
4Science:task/dspace-9_x/DURACOM-347
Apr 9, 2026
Merged

[Port dspace-9_x] Fix accessibility issues with placeholder text in submission forms by removing placeholders#5447
tdonohue merged 10 commits intoDSpace:dspace-9_xfrom
4Science:task/dspace-9_x/DURACOM-347

Conversation

@FrancescoMolinaro
Copy link
Copy Markdown
Contributor

References

Fixes #4198
Manual backport of #4199

Description

Following what is described in https://www.deque.com/blog/accessible-forms-the-problem-with-placeholders/ as an issue with placeholder, this PR removes all placeholders on submission form fields (replacing them with labels where needed)

Instructions for Reviewers

Placeholders should no longer exist on any fields within the submission form. The Series/Report No. field now has sublabels.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FrancescoMolinaro : I gave this a review today, comparing it to #4199. However, I think there's a small change that is missing in this backport. Please see my inline comment below.

@tdonohue tdonohue added accessibility component: submission 1 APPROVAL pull request only requires a single approval to merge labels Apr 8, 2026
@tdonohue tdonohue added this to the 9.3 milestone Apr 8, 2026
@FrancescoMolinaro
Copy link
Copy Markdown
Contributor Author

Hi @tdonohue, thanks for the catch, I have added the missing change, should be ok now.

Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @FrancescoMolinaro ! This looks correct to me now.

@github-project-automation github-project-automation Bot moved this to 👍 Reviewer Approved in DSpace Maintenance (9.x, 8.x, 7.6.x) Apr 9, 2026
@tdonohue tdonohue merged commit 150dd9c into DSpace:dspace-9_x Apr 9, 2026
16 checks passed
@github-project-automation github-project-automation Bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace Maintenance (9.x, 8.x, 7.6.x) Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge accessibility component: submission

Projects

Development

Successfully merging this pull request may close these issues.

2 participants