[Port dspace-9_x] Fix accessibility issues with placeholder text in submission forms by removing placeholders#5447
Merged
tdonohue merged 10 commits intoDSpace:dspace-9_xfrom Apr 9, 2026
Conversation
…ngly used placeholder in date legend
…concat/series (replace with labels)
Merged
12 tasks
tdonohue
reviewed
Apr 8, 2026
Member
tdonohue
left a comment
There was a problem hiding this comment.
@FrancescoMolinaro : I gave this a review today, comparing it to #4199. However, I think there's a small change that is missing in this backport. Please see my inline comment below.
Contributor
Author
|
Hi @tdonohue, thanks for the catch, I have added the missing change, should be ok now. |
tdonohue
approved these changes
Apr 9, 2026
Member
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @FrancescoMolinaro ! This looks correct to me now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Fixes #4198
Manual backport of #4199
Description
Following what is described in https://www.deque.com/blog/accessible-forms-the-problem-with-placeholders/ as an issue with placeholder, this PR removes all placeholders on submission form fields (replacing them with labels where needed)
Instructions for Reviewers
Placeholders should no longer exist on any fields within the submission form. The Series/Report No. field now has sublabels.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.