Skip to content

Disable autocomplete for script selector#5499

Merged
tdonohue merged 1 commit intoDSpace:mainfrom
atmire:disable-autocomplete-script-select
Apr 16, 2026
Merged

Disable autocomplete for script selector#5499
tdonohue merged 1 commit intoDSpace:mainfrom
atmire:disable-autocomplete-script-select

Conversation

@artlowel
Copy link
Copy Markdown
Member

References

None

Description

Disable the browser's autocomplete on the dropdown to select a script in the scripts and processes Admin UI.

Instructions for Reviewers

  • Before deploying this PR, deploy the main branch, go the the new process page, and type (and press enter) on a few queries in that script selector. You should see the browser's autocomplete over the dropdown
  • Then deploy this PR and try those same queries. You should no longer see that autocomplete

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@artlowel artlowel requested a review from tdonohue April 16, 2026 15:10
@artlowel artlowel self-assigned this Apr 16, 2026
@artlowel artlowel added bug tools:processes Related to Scripts & Processes (new to DSpace 7) labels Apr 16, 2026
@artlowel artlowel added the 1 APPROVAL pull request only requires a single approval to merge label Apr 16, 2026
@tdonohue tdonohue added this to the 10.0 milestone Apr 16, 2026
@tdonohue tdonohue added port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release labels Apr 16, 2026
@artlowel artlowel changed the title Disable autocomplet for script selector Disable autocomplete for script selector Apr 16, 2026
@artlowel artlowel moved this to 👀 Under Review in DSpace 10.0 Release Apr 16, 2026
@tdonohue
Copy link
Copy Markdown
Member

Thanks @artlowel ! I'll give this a test today as this has been annoying me. Also flagged for backporting to all releases as I think this issue happens in all supported releases.

Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @artlowel ! This works perfectly and resolves a long standing annoyance of mine :)

@github-project-automation github-project-automation bot moved this from 👀 Under Review to 👍 Reviewer Approved in DSpace 10.0 Release Apr 16, 2026
@tdonohue tdonohue merged commit 825b39f into DSpace:main Apr 16, 2026
18 of 19 checks passed
@github-project-automation github-project-automation bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 10.0 Release Apr 16, 2026
@dspace-bot
Copy link
Copy Markdown
Contributor

Backport failed for dspace-7_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-7_x
git worktree add -d .worktree/backport-5499-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-5499-to-dspace-7_x
git switch --create backport-5499-to-dspace-7_x
git cherry-pick -x 581e98f167b5c781369f511c4bbbfbc4b9c3106a

@dspace-bot
Copy link
Copy Markdown
Contributor

Backport failed for dspace-8_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-8_x
git worktree add -d .worktree/backport-5499-to-dspace-8_x origin/dspace-8_x
cd .worktree/backport-5499-to-dspace-8_x
git switch --create backport-5499-to-dspace-8_x
git cherry-pick -x 581e98f167b5c781369f511c4bbbfbc4b9c3106a

@dspace-bot
Copy link
Copy Markdown
Contributor

Successfully created backport PR for dspace-9_x:

@tdonohue
Copy link
Copy Markdown
Member

@artlowel : This could only be autobackported to 9.x. But, that's the only version we guarantee bug-fix backports too.

However, if you wanted to help this get into 8.x and 7.x, please feel free to create a backport PR (it might work fine to just create one for dspace-8_x which we can backport automatically to 7.x). If you create the backport, feel free to assign to me & I'll get it merged quickly. Thanks!

@artlowel
Copy link
Copy Markdown
Member Author

@tdonohue done: #5507

I did a quick check if I could cherrypick that on dspace-7.x and that worked without conflicts, so the auto backport should work there. If it still somehow doesn't, let me know and I'll create a PR for that as well

@tdonohue
Copy link
Copy Markdown
Member

@tdonohue tdonohue removed port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release labels Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug tools:processes Related to Scripts & Processes (new to DSpace 7)

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants