Skip to content

Fix modal accessible name #5506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jesielviana wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix modal accessible name #5506

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
aa0b718
add accessible names to modals using aria-labelledby
jesielviana Apr 17, 2026
86523e9
Fix unclosed HTML tags
jesielviana Apr 17, 2026
d3dec4d
Returning IDs(acceptModal, ignoreModal) used for functionality on th…
jesielviana May 20, 2026
5b2c71a
Returning IDs(rejectModal, undoModal) used for functionality on the …
jesielviana May 21, 2026
6f15870
Fix modal aria-label for specific ids in quality-assurance-events.com…
jesielviana May 21, 2026
22c8a56
Fix lint
jesielviana May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app/admin/admin-edit-user-agreement/admin-edit-user-agreement.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ <h2>{{'admin.edit-user-agreement.header' | translate}}</h2>

<ng-template #content let-c="close" let-d="dismiss">
<div class="modal-header">
<h4 class="modal-title text-info">{{'admin.edit-user-agreement.confirm.title' | translate}}</h4>
<h4 id="modal-title" class="modal-title text-info">{{'admin.edit-user-agreement.confirm.title' | translate}}</h4>
</div>
<div class="modal-body">
<p>{{'admin.edit-user-agreement.confirm.info' | translate}}</p>
Expand Down
4 changes: 2 additions & 2 deletions src/app/admin/admin-ldn-services/ldn-service-form/ldn-service-form.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,10 +312,10 @@ <h1 class="flex-grow-1">{{ isNewService ? ('ldn-create-service.title' | translat
<ng-template #confirmModal>
<div class="modal-header">
@if (!isNewService) {
<h4>{{'service.overview.edit.modal' | translate }}</h4>
<h4 id="modal-title" class="modal-title">{{'service.overview.edit.modal' | translate }}</h4>
}
@if (isNewService) {
<h4>{{'service.overview.create.modal' | translate }}</h4>
<h4 id="modal-title" class="modal-title">{{'service.overview.create.modal' | translate }}</h4>
}
<button (click)="closeModal()" aria-label="Close" class="btn-close" type="button">
</button>
Expand Down
2 changes: 1 addition & 1 deletion ...app/admin/admin-ldn-services/ldn-services-directory/ldn-services-directory.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ <h1 class="flex-grow-1">{{ 'ldn-registered-services.title' | translate }}</h1>

<div class="modal-header">
<div>
<h4>{{'service.overview.delete.header' | translate }}</h4>
<h4 id="modal-title" class="modal-title">{{'service.overview.delete.header' | translate }}</h4>
</div>
<button (click)="closeModal()" aria-label="Close"
[attr.aria-label]="'ldn-service-overview-close-modal' | translate"
Expand Down
2 changes: 1 addition & 1 deletion ...admin-notify-dashboard/admin-notify-detail-modal/admin-notify-detail-modal.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div class="modal-header">
<h4 class="modal-title">{{'notify-message-modal.title' | translate}}</h4>
<h4 id="modal-title" class="modal-title">{{'notify-message-modal.title' | translate}}</h4>
<button type="button" class="btn-close" aria-label="Close" (click)="activeModal.dismiss('Cross click')">
</button>
</div>
Expand Down
3 changes: 2 additions & 1 deletion ...ace-item/supervision-order-group-selector/supervision-order-group-selector.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<div>
<div class="modal-header">{{'supervision-group-selector.header' | translate}}
<div class="modal-header">
<h4 id="modal-title" class="modal-title h4 mb-0">{{'supervision-group-selector.header' | translate}}</h4>
<button type="button" class="btn-close" (click)="close()" aria-label="Close">
</button>
</div>
Expand Down
2 changes: 2 additions & 0 deletions src/app/app.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,8 @@ export class AppComponent implements OnInit, AfterViewInit {
return true;
};

this.modalConfig.ariaLabelledBy = 'modal-title';

this.isAuthBlocking$ = this.store.pipe(
select(isAuthenticationBlocking),
distinctUntilChanged(),
Expand Down
2 changes: 1 addition & 1 deletion ...-groups/research-entities/submission/name-variant-modal/name-variant-modal.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div class="modal-header">
<h4 class="modal-title">New name variant</h4>
<h4 id="modal-title" class="modal-title">New name variant</h4>
<button type="button" class="btn-close" aria-label="Close" (click)="modal.dismiss('Cross click')">
</button>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/app/external-log-in/external-log-in/external-log-in.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ <h4 class="mt-2">{{ 'external-login.component.or' | translate }}</h4>

<ng-template #loginModal let-c="close" let-d="dismiss">
<div class="modal-header">
<h4 class="modal-title text-info"> {{ 'external-login.connect-to-existing-account.label' | translate }}</h4>
<h4 id="modal-title" class="modal-title text-info"> {{ 'external-login.connect-to-existing-account.label' | translate }}</h4>
</div>
<div class="modal-body">
<div class="row justify-content-center">
Expand Down
6 changes: 3 additions & 3 deletions src/app/item-page/edit-item-page/item-delete/item-delete.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ <h5 (click)="setSelected(typeDto.relationshipType, !selected)">
<ng-template #virtualMetadataModal>
<div class="thumb-font-1">
<div class="modal-header">
{{'virtual-metadata.delete-item.modal-head' | translate}}
<h4 id="modal-title" class="modal-title h4 mb-0">{{'virtual-metadata.delete-item.modal-head' | translate}}</h4>
<button type="button" class="btn-close"
(click)="closeVirtualMetadataModal()" aria-label="Close">
</button>
Expand Down Expand Up @@ -86,9 +86,9 @@ <h5 (click)="setSelected(typeDto.relationshipType, !selected)">

<ng-template #deleteConfirmationModal>
<div class="modal-header bg-light text-dark">
<h5 class="modal-title">
<h4 id="modal-title" class="modal-title">
{{'item.edit.delete.confirmation-title' | translate}}
</h5>
</h4>
<button type="button" class="btn-close" aria-label="Close" (click)="modalRef.close()"></button>
</div>
<div class="modal-body">
Expand Down
3 changes: 2 additions & 1 deletion src/app/item-page/edit-item-page/virtual-metadata/virtual-metadata.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<div [ngClass]="showThumbnails ? 'hide-modal-thumbnail-column' : ''">
<div class="modal-header">{{'virtual-metadata.delete-relationship.modal-head' | translate}}
<div class="modal-header">
<h4 id="modal-title" class="modal-title h4 mb-0">{{'virtual-metadata.delete-relationship.modal-head' | translate}}</h4>
Copy link
Copy Markdown

@lgeggleston lgeggleston May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By changing this into an h4, it's also changing to the automatic style of an h4 and much larger font. While you could override that I'm sure, I think adding a semantic header can be out of the scope of this ticket and it may just be best to leave this element as a <span>. Similarly, in the cases here where there are already header elements for the title (for example submission-import-external-preview), I don't think this should change the existing h2 either.

I agree that standardizing the modals further is a good idea generally, but if anything a standard would probably be h2 for a modal header. Maybe a separate ticket for visual/semantic headers on modals would make sense in this case?

Copy link
Copy Markdown
Contributor Author

@jesielviana jesielviana May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to standardize all modal titles as h4 elements for consistency.

Copy link
Copy Markdown

@lgeggleston lgeggleston May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fair! I would love to check opinions from other developers before moving forward with that though, since there have been various thoughts (see past changes to modal headers and other discussions around header structure).

It would be great to get the label/accessibility part of this fix merged though - Would you be willing to move any changes to the semantic structure of headers (any new h4s and changes to existing h*) into a followup issue (and/or PR) to continue that conversation?

<button type="button" class="btn-close" (click)="close.emit()" aria-label="Close">
</button>
</div>
Expand Down
3 changes: 2 additions & 1 deletion ...p/item-page/versions/item-versions-delete-modal/item-versions-delete-modal.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<div>
<div class="modal-header">{{'item.version.delete.modal.header' | translate}}
<div class="modal-header">
<h4 id="modal-title" class="modal-title h4 mb-0">{{'item.version.delete.modal.header' | translate}}</h4>
<button type="button" class="btn-close" (click)="onModalClose()" aria-label="Close">
</button>
</div>
Expand Down
5 changes: 3 additions & 2 deletions ...item-page/versions/item-versions-summary-modal/item-versions-summary-modal.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
@if ((this.submitted$ | async) !== true) {
<div>
<div class="modal-header">{{'item.version.create.modal.header' | translate}}
<div class="modal-header">
<h4 id="modal-title" class="modal-title h4 mb-0">{{'item.version.create.modal.header' | translate}}</h4>
<button type="button" class="btn-close" (click)="onModalClose()" aria-label="Close">
</button>
</div>
Expand Down Expand Up @@ -37,7 +38,7 @@
</div>
</div>
} @else {
<div class="modal-header">{{'item.version.create.modal.submitted.header' | translate}}</div>
<div class="modal-header"><h4 id="modal-title" class="modal-title h4 mb-0">{{'item.version.create.modal.submitted.header' | translate}}</h4></div>
<div class="modal-body">
<p>{{'item.version.create.modal.submitted.text' | translate}}</p>
<div class="d-flex justify-content-center">
Expand Down
3 changes: 2 additions & 1 deletion src/app/my-dspace-page/collection-selector/collection-selector.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<div>
<div class="modal-header">{{'dso-selector.create.submission.head' | translate}}
<div class="modal-header">
<h4 id="modal-title" class="modal-title h4 mb-0">{{'dso-selector.create.submission.head' | translate}}</h4>
<button type="button" class="btn-close" (click)="close()" aria-label="Close">
</button>
</div>
Expand Down
8 changes: 4 additions & 4 deletions src/app/notifications/qa/events/quality-assurance-events.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ <h2 class="border-bottom pb-2">

<ng-template #acceptModal let-modal>
<div class="modal-header">
<h4 class="modal-title" id="acceptModal">{{'quality-assurance.event.sure' | translate}}</h4>
Comment thread
jesielviana marked this conversation as resolved.
<h4 class="modal-title" id="modal-title">{{'quality-assurance.event.sure' | translate}}</h4>
</div>
Comment thread
jesielviana marked this conversation as resolved.
<div class="modal-body">
<p>{{'quality-assurance.event.accept.description' | translate}}</p>
Expand All @@ -314,7 +314,7 @@ <h4 class="modal-title" id="acceptModal">{{'quality-assurance.event.sure' | tran

<ng-template #ignoreModal let-modal>
<div class="modal-header">
<h1 class="modal-title h4" id="ignoreModal">{{'quality-assurance.event.sure' | translate}}</h1>
<h4 class="modal-title h4" id="modal-title">{{'quality-assurance.event.sure' | translate}}</h4>
</div>
<div class="modal-body">
<p>{{'quality-assurance.event.ignore.description' | translate}}</p>
Expand All @@ -331,7 +331,7 @@ <h1 class="modal-title h4" id="ignoreModal">{{'quality-assurance.event.sure' | t

<ng-template #rejectModal let-modal>
<div class="modal-header">
<h1 class="modal-title h4" id="rejectModal">{{'quality-assurance.event.sure' | translate}}</h1>
<h4 class="modal-title h4" id="modal-title">{{'quality-assurance.event.sure' | translate}}</h4>
</div>
<div class="modal-body">
<p>{{'quality-assurance.event.reject.description' | translate}}</p>
Expand All @@ -348,7 +348,7 @@ <h1 class="modal-title h4" id="rejectModal">{{'quality-assurance.event.sure' | t

<ng-template #undoModal let-modal>
<div class="modal-header">
<h1 class="modal-title h4" id="undoModal">{{'quality-assurance.event.sure' | translate}}</h1>
<h4 class="modal-title h4" id="modal-title">{{'quality-assurance.event.sure' | translate}}</h4>
</div>
<div class="modal-body">
<p>{{'quality-assurance.event.undo.description' | translate}}</p>
Expand Down
2 changes: 1 addition & 1 deletion src/app/process-page/detail/process-detail.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ <h1 class="flex-grow-1">
<div>
<div class="modal-header">
<div>
<h4>{{'process.detail.delete.header' | translate }}</h4>
<h4 id="modal-title" class="modal-title">{{'process.detail.delete.header' | translate }}</h4>
</div>
<button type="button" class="btn-close"
(click)="closeModal()" aria-label="Close">
Expand Down
2 changes: 1 addition & 1 deletion src/app/process-page/overview/process-overview.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ <h1 class="flex-grow-1">{{'process.overview.title' | translate}}</h1>

<div class="modal-header">
<div>
<h4>{{'process.overview.delete.header' | translate }}</h4>
<h4 id="modal-title" class="modal-title">{{'process.overview.delete.header' | translate }}</h4>
</div>
<button type="button" class="btn-close"
(click)="closeModal()" aria-label="Close">
Expand Down
2 changes: 1 addition & 1 deletion src/app/profile-page/profile-claim-item-modal/profile-claim-item-modal.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div>
<div class="modal-header"><h4>{{'dso-selector.claim.item.head' | translate}}</h4>
<div class="modal-header"><h4 id="modal-title" class="modal-title">{{'dso-selector.claim.item.head' | translate}}</h4>
<button type="button" class="btn-close" (click)="close()" aria-label="Close">
</button>
</div>
Expand Down
2 changes: 1 addition & 1 deletion ...ontrol-select-bitstreams-modal/item-access-control-select-bitstreams-modal.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div class="modal-header">
<h4 class="modal-title">
<h4 id="modal-title" class="modal-title">
{{'access-control-select-bitstreams-modal.title' | translate}}
</h4>
<button type="button" class="btn-close" aria-label="Close"
Expand Down
3 changes: 2 additions & 1 deletion src/app/shared/confirmation-modal/confirmation-modal.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<div>
<div class="modal-header">{{ headerLabel | translate:{ dsoName: name } }}
<div class="modal-header">
<h4 id="modal-title" class="modal-title h4 mb-0">{{ headerLabel | translate:{ dsoName: name } }}</h4>
<button type="button" class="btn-close" (click)="close()" aria-label="Close">
</button>
</div>
Expand Down
6 changes: 3 additions & 3 deletions src/app/shared/correction-suggestion/item-withdrawn-reinstate-modal.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@
<div>
@if (this.canWithdraw) {
<div class="modal-header">
{{ 'item.qa.withdrawn.modal.header' | translate }}
<h4 id="modal-title" class="modal-title h4 mb-0">{{ 'item.qa.withdrawn.modal.header' | translate }}</h4>
<button type="button" class="btn-close" (click)="onModalClose()" aria-label="Close">
</button>
</div>
} @else {
@if (!this.canWithdraw) {
<div class="modal-header">
{{'item.qa.reinstate.modal.header' | translate}}
<h4 id="modal-title" class="modal-title h4 mb-0">{{'item.qa.reinstate.modal.header' | translate}}</h4>
<button type="button" class="btn-close" (click)="onModalClose()" aria-label="Close">
</button>
</div>
Expand Down Expand Up @@ -46,7 +46,7 @@
</div>
</div>
} @else {
<div class="modal-header">{{'item.qa.withdrawn.modal.submitted.header' | translate}}</div>
<div class="modal-header"><h4 id="modal-title" class="modal-title h4 mb-0">{{'item.qa.withdrawn.modal.submitted.header' | translate}}</h4></div>
<div class="modal-body">
<div class="d-flex justify-content-center">
<ds-loading [showMessage]="false"></ds-loading>
Expand Down
5 changes: 3 additions & 2 deletions ...appers/create-collection-parent-selector/create-collection-parent-selector.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
<div>
<div class="modal-header">{{'dso-selector.'+ action + '.' + objectType.toString().toLowerCase() + '.head' | translate}}
<div class="modal-header">
<h4 id="modal-title" class="modal-title h4 mb-0">{{'dso-selector.'+ action + '.' + objectType.toString().toLowerCase() + '.head' | translate}}</h4>
<button type="button" class="btn-close" (click)="close()" aria-label="Close">
</button>
</div>
<div class="modal-body">
<div class="modal-body">
@if (header) {
<span class="h5 px-2">{{header | translate}}</span>
}
Expand Down
5 changes: 3 additions & 2 deletions ...wrappers/create-community-parent-selector/create-community-parent-selector.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
<div>
<div class="modal-header">{{'dso-selector.'+ action + '.' + objectType.toString().toLowerCase() + '.head' | translate}}
<div class="modal-header">
<h4 id="modal-title" class="modal-title h4 mb-0">{{'dso-selector.'+ action + '.' + objectType.toString().toLowerCase() + '.head' | translate}}</h4>
<button type="button" class="btn-close" (click)="close()" aria-label="Close">
</button>
</div>
<div class="modal-body">
<div class="modal-body">
@if ((isAdmin$ | async)) {
<div data-test="admin-div">
<button class="btn btn-outline-primary btn-lg btn-block w-100" (click)="selectObject(undefined)">{{'dso-selector.create.community.top-level' | translate}}</button>
Expand Down
5 changes: 3 additions & 2 deletions ...tor/modal-wrappers/create-item-parent-selector/create-item-parent-selector.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
<div>
<div class="modal-header">{{'dso-selector.'+ action + '.' + objectType.toString().toLowerCase() + '.head' | translate}}
<div class="modal-header">
<h4 id="modal-title" class="modal-title h4 mb-0">{{'dso-selector.'+ action + '.' + objectType.toString().toLowerCase() + '.head' | translate}}</h4>
<button type="button" class="btn-close" (click)="close()" aria-label="Close">
</button>
</div>
<div class="modal-body">
<div class="modal-body">
@if (header) {
<span class="h5 px-2">{{header | translate}}</span>
}
Expand Down
3 changes: 2 additions & 1 deletion src/app/shared/dso-selector/modal-wrappers/dso-selector-modal-wrapper.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<div>
<div class="modal-header">{{'dso-selector.'+ action + '.' + objectType.toString().toLowerCase() + '.head' | translate}}
<div class="modal-header">
<h4 id="modal-title" class="modal-title h4 mb-0">{{'dso-selector.'+ action + '.' + objectType.toString().toLowerCase() + '.head' | translate}}</h4>
<button type="button" class="btn-close" (click)="close()" aria-label="Close">
</button>
</div>
Expand Down
5 changes: 3 additions & 2 deletions ...-selector/modal-wrappers/edit-collection-selector/edit-collection-selector.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
<div>
<div class="modal-header">{{'dso-selector.'+ action + '.' + objectType.toString().toLowerCase() + '.head' | translate}}
<div class="modal-header">
<h4 id="modal-title" class="modal-title h4 mb-0">{{'dso-selector.'+ action + '.' + objectType.toString().toLowerCase() + '.head' | translate}}</h4>
<button type="button" class="btn-close" (click)="close()" aria-label="Close">
</button>
</div>
<div class="modal-body">
<div class="modal-body">
@if (header) {
<span class="h5 px-2">{{header | translate}}</span>
}
Expand Down
5 changes: 3 additions & 2 deletions ...so-selector/modal-wrappers/edit-community-selector/edit-community-selector.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
<div>
<div class="modal-header">{{'dso-selector.'+ action + '.' + objectType.toString().toLowerCase() + '.head' | translate}}
<div class="modal-header">
<h4 id="modal-title" class="modal-title h4 mb-0">{{'dso-selector.'+ action + '.' + objectType.toString().toLowerCase() + '.head' | translate}}</h4>
<button type="button" class="btn-close" (click)="close()" aria-label="Close">
</button>
</div>
<div class="modal-body">
<div class="modal-body">
@if (header) {
<span class="h5 px-2">{{header | translate}}</span>
}
Expand Down
5 changes: 3 additions & 2 deletions ...p/shared/dso-selector/modal-wrappers/edit-item-selector/edit-item-selector.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
<div>
<div class="modal-header">{{'dso-selector.'+ action + '.' + objectType.toString().toLowerCase() + '.head' | translate}}
<div class="modal-header">
<h4 id="modal-title" class="modal-title h4 mb-0">{{'dso-selector.'+ action + '.' + objectType.toString().toLowerCase() + '.head' | translate}}</h4>
<button type="button" class="btn-close" (click)="close()" aria-label="Close">
</button>
</div>
<div class="modal-body">
<div class="modal-body">
@if (header) {
<span class="h5 px-2">{{header | translate}}</span>
}
Expand Down
2 changes: 1 addition & 1 deletion ...s-dynamic-form-ui/models/relation-group/modal/dynamic-relation-group-modal.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<div class="modal-content">
<div class="modal-header">
<h5 class="modal-title">{{ getHeader() }}</h5>
<h4 id="modal-title" class="modal-title">{{ getHeader() }}</h4>
</div>
<div class="modal-body">

Expand Down
2 changes: 1 addition & 1 deletion src/app/shared/form/vocabulary-treeview-modal/vocabulary-treeview-modal.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div class="modal-header">
<h4 class="modal-title">{{'vocabulary-treeview.header' | translate}}</h4>
<h4 id="modal-title" class="modal-title">{{'vocabulary-treeview.header' | translate}}</h4>
<button type="button" class="btn-close" aria-label="Close" (click)="activeModal.dismiss('Cross click')">
</button>
</div>
Expand Down
3 changes: 2 additions & 1 deletion src/app/shared/idle-modal/idle-modal.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<div>
<div class="modal-header" id="idle-modal.header">{{ "idle-modal.header" | translate }}
<div class="modal-header">
<h4 id="idle-modal.header" class="modal-title h4 mb-0">{{ "idle-modal.header" | translate }}</h4>
<button type="button" class="btn-close" (click)="closePressed()" aria-label="Close">
</button>
</div>
Expand Down
2 changes: 1 addition & 1 deletion ...pp/shared/mydspace-actions/claimed-task/reject/claimed-task-actions-reject.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

<ng-template #rejectModal let-c="close" let-d="dismiss">
<div class="modal-header">
<h4 class="modal-title">{{'submission.workflow.tasks.claimed.reject.reason.title' | translate}}</h4>
<h4 id="modal-title" class="modal-title">{{'submission.workflow.tasks.claimed.reject.reason.title' | translate}}</h4>
<button type="button"
class="btn-close"
aria-label="Close"
Expand Down
2 changes: 1 addition & 1 deletion src/app/shared/mydspace-actions/workspaceitem/workspaceitem-actions.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

<ng-template #content let-c="close" let-d="dismiss">
<div class="modal-header">
<div class="modal-title text-danger h4">{{'submission.general.discard.confirm.title' | translate}}</div>
<h4 id="modal-title" class="modal-title text-danger h4">{{'submission.general.discard.confirm.title' | translate}}</h4>
<button type="button" id="delete_close" class="btn-close" aria-label="Close" (click)="d('cancel')">
</button>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/app/shared/resource-policies/form/resource-policy-form.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@

<ng-template #content let-modal>
<div class="modal-header">
<h4 class="modal-title" id="modal-basic-title">{{ 'resource-policies.form.eperson-group-list.modal.header' | translate }}</h4>
<h4 class="modal-title" id="modal-title">{{ 'resource-policies.form.eperson-group-list.modal.header' | translate }}</h4>
<button type="button" class="btn-close" aria-label="Close" (click)="modal.close()">
</button>
</div>
Expand Down
3 changes: 2 additions & 1 deletion src/app/shared/search-form/scope-selector-modal/scope-selector-modal.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<div>
<div class="modal-header">{{'dso-selector.'+ action + '.' + objectType.toString().toLowerCase() + '.head' | translate}}
<div class="modal-header">
<h4 id="modal-title" class="modal-title h4 mb-0">{{'dso-selector.'+ action + '.' + objectType.toString().toLowerCase() + '.head' | translate}}</h4>
<button type="button" class="btn-close" (click)="selectObject(undefined)" aria-label="Close">
</button>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/app/shared/subscriptions/subscription-modal/subscription-modal.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
@if (subscriptionForm) {
<form [formGroup]="subscriptionForm" (ngSubmit)="submit()" data-test="subscription-form">
<div class="modal-header">
<h4 class="modal-title">{{'subscriptions.modal.title' | translate}}</h4>
<h4 id="modal-title" class="modal-title">{{'subscriptions.modal.title' | translate}}</h4>
<button type="button" class="btn-close" aria-label="Close" (click)="activeModal.close()">
</button>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/app/submission/form/footer/submission-form-footer.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@

<ng-template #content let-c="close" let-d="dismiss">
<div class="modal-header">
<h4 class="modal-title text-danger">{{'submission.general.discard.confirm.title' | translate}}</h4>
<h4 id="modal-title" class="modal-title text-danger">{{'submission.general.discard.confirm.title' | translate}}</h4>
<button type="button" class="btn-close" aria-label="Close" (click)="d('cancel')">
</button>
</div>
Expand Down
Loading
Loading