Skip to content

fix #5166: add explanation of ORCID iD benefits#5523

Open
guillermo-escire wants to merge 1 commit intoDSpace:mainfrom
guillermo-escire:feature/5166
Open

fix #5166: add explanation of ORCID iD benefits#5523
guillermo-escire wants to merge 1 commit intoDSpace:mainfrom
guillermo-escire:feature/5166

Conversation

@guillermo-escire
Copy link
Copy Markdown
Contributor

References

Fixes #5166

Description

Adds an explanation of the benefits of having and connecting an ORCID iD to the ORCID auth page, as required for ORCID CSP certification. Includes a link for users who don't yet have an ORCID iD.

Instructions for Reviewers

List of changes in this PR:

  • Added benefits description text in orcid-auth.component.html following ORCID OAuth sign-in guidelines ("Explaining ORCID" section)
  • Added link to https://info.orcid.org/researchers/#why for users without an ORCID iD
  • Added i18n keys (person.page.orcid.benefits.description, person.page.orcid.benefits.learn-more) in en.json

To test:

  1. Go to a Person profile page
  2. Navigate to the ORCID section
  3. If ORCID is not linked, you should see the benefits description text and the "learn more" link below the info alert

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@guillermo-escire
Copy link
Copy Markdown
Contributor Author

The failing test (SubmissionService - redirectToEditItem) is unrelated to this PR.
It was already failing before these changes due to a duplicate spy setup in submission.service.spec.ts.

@lgeggleston lgeggleston added improvement usability identifiers: ORCID integration: ORCID Related to integration with ORCID identifier system labels Apr 22, 2026
@lgeggleston lgeggleston moved this to 🙋 Needs Reviewers Assigned in DSpace 11.0 Release Apr 22, 2026
@tdonohue
Copy link
Copy Markdown
Member

@guillermo-escire : Just a note...you don't need to force a rerun of tests by creating an empty commit (as doing so creates unnecessary commits). Those of us with "write" permissions to this repositories can just rerun the tests whenever they fail unexpectedly. So, feel free to point out if the test failure looks unrelated, and one of us can just rerun the tests to see if they succeed on the second or third run.

I would appreciate it if you could "squash" (via a git rebase) this PR back into a single commit. We don't want to have empty commits in our codebase as they serve no purpose.

@guillermo-escire
Copy link
Copy Markdown
Contributor Author

Hi @tdonohue, thanks for the tip! I've squashed the commits into one. I'll keep that in mind for future PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

identifiers: ORCID improvement integration: ORCID Related to integration with ORCID identifier system usability

Projects

Status: 🙋 Needs Reviewers Assigned

Development

Successfully merging this pull request may close these issues.

Provide explanation of benefits of having an ORCID iD

3 participants