Skip to content

fix #5166: add explanation of ORCID iD benefits #5523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guillermo-escire wants to merge 1 commit into
base: main
Choose a base branch
from
+21 −0
Open

fix #5166: add explanation of ORCID iD benefits #5523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/app/item-page/orcid-page/orcid-auth/orcid-auth.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,16 @@ <h1>{{'person.orcid.registry.auth' | translate}}</h1>
<div class="col">
<ds-alert [type]="AlertType.Info">{{ getOrcidNotLinkedMessage() }}</ds-alert>
</div>
</div>
<div class="row mb-3">
<div class="col">
<p data-test="orcid-benefits-description">{{ 'person.page.orcid.benefits.description' | translate }}</p>
<p>
<a data-test="orcid-benefits-learn-more" href="https://info.orcid.org/researchers/#why" target="_blank" rel="noopener noreferrer">
{{ 'person.page.orcid.benefits.learn-more' | translate }}
</a>
</p>
</div>
</div>
<div class="row">
<div class="col">
Expand Down
7 changes: 7 additions & 0 deletions src/app/item-page/orcid-page/orcid-auth/orcid-auth.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,13 @@ describe('OrcidAuthComponent test suite', () => {
fixture.detectChanges();
}));

it('should display orcid benefits description and learn more link', fakeAsync(() => {
const benefitsDescription = fixture.debugElement.query(By.css('[data-test="orcid-benefits-description"]'));
const benefitsLink = fixture.debugElement.query(By.css('[data-test="orcid-benefits-learn-more"]'));
expect(benefitsDescription).toBeTruthy();
expect(benefitsLink).toBeTruthy();
}));

it('should create', fakeAsync(() => {
const orcidLinked = fixture.debugElement.query(By.css('[data-test="orcidLinked"]'));
const orcidNotLinked = fixture.debugElement.query(By.css('[data-test="orcidNotLinked"]'));
Expand Down
4 changes: 4 additions & 0 deletions src/assets/i18n/en.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4154,6 +4154,10 @@

"person.page.orcid": "ORCID",

"person.page.orcid.benefits.description": "ORCID is a free, unique, persistent identifier (PID) for individuals to use as they engage in research, scholarship, and innovation activities. It can also help you save time when you use your ORCID to sign into systems like this one.",

"person.page.orcid.benefits.learn-more": "Don't have an ORCID iD yet? Learn more at orcid.org",

"person.page.staffid": "Staff ID",

"person.page.titleprefix": "Person: ",
Expand Down
Loading