Skip to content

fix(i18n): correct article usage in dso-selector placeholder#5530

Merged
tdonohue merged 1 commit intoDSpace:mainfrom
MukundaKatta:docs/i18n-edit-item-an-item
Apr 23, 2026
Merged

fix(i18n): correct article usage in dso-selector placeholder#5530
tdonohue merged 1 commit intoDSpace:mainfrom
MukundaKatta:docs/i18n-edit-item-an-item

Conversation

@MukundaKatta
Copy link
Copy Markdown
Contributor

Fixes #5528.

Two article-placement bugs in src/assets/i18n/en.json5:

1. dso-selector.placeholder was "Search for a {{ type }}". When type is item (which starts with a vowel) the rendered text became "Search for a item". The selector is used across community / collection / item selections, so there's no single correct English article. Dropping the article makes the template grammatically neutral for all types:

- "dso-selector.placeholder": "Search for a {{ type }}",
+ "dso-selector.placeholder": "Search for {{ type }}",

Note: the dso-selector.placeholder.type.{community,collection,item} values ("community", "collection", "item") are reused by dso-selector.no-results ("No {{ type }} found"), so embedding the article into those values would break that usage. Removing the article from the placeholder template is the smallest change that fixes all three rendered variants without disturbing other callers.

2. resource-policies.form.eperson-group-list.tab.eperson had "Search for a ePerson" (vowel-start noun again) — fixed to "Search for an ePerson".

Docs/translation only; no code or logic changes. Only en.json5 touched — translators can decide how each locale handles article agreement.

@lgeggleston lgeggleston added improvement i18n / l10n Internationalisation and localisation, related to message catalogs testathon Reported by a tester during Community Testathon labels Apr 23, 2026
@lgeggleston lgeggleston moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Apr 23, 2026
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @MukundaKatta ! The changes to the translation files look good and make sense to me. I agree this solves the minor bug.

I believe this can also be backported easily, so flagging this to be auto-backported to all supported versions (7.x, 8.x, and 9.x)

@github-project-automation github-project-automation Bot moved this from 🙋 Needs Reviewers Assigned to 👍 Reviewer Approved in DSpace 10.0 Release Apr 23, 2026
@tdonohue tdonohue added this to the 10.0 milestone Apr 23, 2026
@tdonohue tdonohue added port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release labels Apr 23, 2026
@tdonohue tdonohue merged commit ffcca7d into DSpace:main Apr 23, 2026
16 checks passed
@github-project-automation github-project-automation Bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 10.0 Release Apr 23, 2026
@dspace-bot
Copy link
Copy Markdown
Contributor

Successfully created backport PR for dspace-7_x:

@dspace-bot
Copy link
Copy Markdown
Contributor

Successfully created backport PR for dspace-8_x:

@dspace-bot
Copy link
Copy Markdown
Contributor

Successfully created backport PR for dspace-9_x:

@tdonohue tdonohue removed port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release labels Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n / l10n Internationalisation and localisation, related to message catalogs improvement low priority testathon Reported by a tester during Community Testathon

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Typo in Edit Item modal search placeholder

4 participants