fix(i18n): correct article usage in dso-selector placeholder#5530
Merged
tdonohue merged 1 commit intoDSpace:mainfrom Apr 23, 2026
Merged
fix(i18n): correct article usage in dso-selector placeholder#5530tdonohue merged 1 commit intoDSpace:mainfrom
tdonohue merged 1 commit intoDSpace:mainfrom
Conversation
tdonohue
approved these changes
Apr 23, 2026
Member
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @MukundaKatta ! The changes to the translation files look good and make sense to me. I agree this solves the minor bug.
I believe this can also be backported easily, so flagging this to be auto-backported to all supported versions (7.x, 8.x, and 9.x)
Contributor
|
Successfully created backport PR for |
Contributor
|
Successfully created backport PR for |
Contributor
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5528.
Two article-placement bugs in
src/assets/i18n/en.json5:1.
dso-selector.placeholderwas"Search for a {{ type }}". Whentypeisitem(which starts with a vowel) the rendered text became "Search for a item". The selector is used across community / collection / item selections, so there's no single correct English article. Dropping the article makes the template grammatically neutral for all types:Note: the
dso-selector.placeholder.type.{community,collection,item}values ("community","collection","item") are reused bydso-selector.no-results("No {{ type }} found"), so embedding the article into those values would break that usage. Removing the article from the placeholder template is the smallest change that fixes all three rendered variants without disturbing other callers.2.
resource-policies.form.eperson-group-list.tab.epersonhad "Search for a ePerson" (vowel-start noun again) — fixed to "Search for an ePerson".Docs/translation only; no code or logic changes. Only
en.json5touched — translators can decide how each locale handles article agreement.