Skip to content

Fix #5534: allow multiple accordions to stay open in Collection Filte…#5547

Open
guillermo-escire wants to merge 1 commit intoDSpace:mainfrom
guillermo-escire:feature/5534
Open

Fix #5534: allow multiple accordions to stay open in Collection Filte…#5547
guillermo-escire wants to merge 1 commit intoDSpace:mainfrom
guillermo-escire:feature/5534

Conversation

@guillermo-escire
Copy link
Copy Markdown
Contributor

References

Fixes #5534

Description

Allows multiple accordions to stay open simultaneously in the Collection Filter Report.
The "Show Collections" button behavior is preserved, closing the Filters accordion and opening the Collections accordion automatically.

Instructions for Reviewers

List of changes in this PR:

  • Set [closeOthers]="false" in the ngb-accordion component to allow multiple panels to be open at the same time.
  • Added explicit collapse('filters') call in the submit() method to preserve the original UX behavior when clicking "Show Collections".
  • Added unit tests to cover: filters collapsing on submit, and both accordions being open simultaneously.

Steps to test:

  1. Open the Collection Filter Report in the admin menu.
  2. Expand the Filters accordion, then manually expand the Collections accordion — both should stay open.
  3. Close one accordion — the other should remain unaffected.
  4. With Filters open, press "Show Collections" — Filters should close and Collections should open with results.
  5. With both open, press "Show Collections" — Filters should close and Collections should refresh with results.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@lgeggleston lgeggleston added improvement 1 APPROVAL pull request only requires a single approval to merge ux User Experience related works testathon Reported by a tester during Community Testathon component: admin reports Related to reporting tools available in adminsitrative menu port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release labels Apr 24, 2026
@lgeggleston lgeggleston moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge component: admin reports Related to reporting tools available in adminsitrative menu improvement port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release testathon Reported by a tester during Community Testathon ux User Experience related works

Projects

Status: 🙋 Needs Reviewers Assigned

Development

Successfully merging this pull request may close these issues.

UX improvement: allow multiple accordions to stay open in Collection Filter Report

2 participants