Fix #5923: To be deleted bitstreams should be highlighted#5924
Conversation
|
The tests completed without errors on my repo, how can I run them again? |
|
@tinsch : Unfortunately, per limits of GitHub, only people with Admin-level permissions in GitHub can trigger a test re-run within a PR. But, I see that was already done for this PR & the tests all passed after a second run. If you notice this sort of thing in the future, just add a comment asking for a test re-run to be triggered, and someone will take care of it. |
|
@bram-maegerman : I see the fixes in this PR are the same idea as your fixes in #5880 (just applied to a different part of DSpace). If you'd be willing to quickly test or review this PR, it'd help us to get this merged quickly. |
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @tinsch ! Code looks good and was tested by @bram-maegerman . Similar to #5880, I've only verified this on 10.x and main, so I'm only backporting to 10.x. If we find this issue exists in earlier releases, it will need to be backported manually.
|
Successfully created backport PR for |
References
Description
This PR adds red highlighting to bitstreams marked for deletion, so the user sees clearly which bitstreams they have selected.
Instructions for Reviewers
I reviewed the PR #5880 and encountered the bug this PR here adresses. The solution for both problems seem to be the same. The issue seems to stem from a bootstrap bug (not sure though, could also be a bug we introduced in our code somehow), so we need to add an explicit extra coloring to
tr.table-dangerrows.List of changes in this PR:
Introduce a css rule to add an explicit red coloring to
tr.table-dangerchildren.Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.