Updated e2e tests

[EikLoe]

References

Add references/links to any related issues or PRs. These may include:

• Cypress.env() was deprecated and needs to be replaced by either cy.env() or Cypress.expose() #5875

Description

Since the Cypress.env() method was deprecated in version 15.10.0, see https://docs.cypress.io/api/cypress-api/env , this PR replaces it by either cy.env() or Cypress.expose() it also updates the cypress config in order to meet the needs of the new methods.

Instructions for Reviewers

List of changes in this PR:

• Replaced all occurrences oc Cypress.env() through either cy.env() or Cypress.expose()
• Moved all "public" variables in the e2e:expose block in the cypress config.

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Run all cypress tests and see, if they pass correctly.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

• My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using npm run lint
• My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• My PR aligns with Accessibility guidelines if it makes changes to the user interface.
• My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
• My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[EikLoe]

Hi @tdonohue ,

I found the problems. The PR is ready now. Could you rerun the 20.x Build / tests? They're failing for some reason.

[tdonohue]

👍 Thanks @EikLoe ! This all looks good to me and it (now) passes all tests. I'm also going to try to auto-backport this to 10.x and 9.x as those both also use Cypress v15.

[dspace-bot]

Backport failed for dspace-9_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-9_x
git worktree add -d .worktree/backport-5937-to-dspace-9_x origin/dspace-9_x
cd .worktree/backport-5937-to-dspace-9_x
git switch --create backport-5937-to-dspace-9_x
git cherry-pick -x d187a2670c327313de2489dc6b3ced61dc1c03aa d2c33aed28c06fbd577240f706c35c2a85210702 a784158393ae7afdd1b176f8bd2864c226997b35

[dspace-bot]

Successfully created backport PR for dspace-10_x:

• [Port dspace-10_x] Updated e2e tests #5940

[tdonohue]

@EikLoe : Looks like only the backport to 10.x succeeded. But, that's probably "good enough" unless you feel like you want this backported further. We only guarantee backports to 10.x (latest major version), so backporting further is optional.