Multi image hint bugfix#5975
Open
mspalti wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
mirador-viewer.servicehas a method to determine whether or not multiple images exist in an Item's IIIF Bundles. When the image count is greater than one a "multi" query parameter is passed as a hint to the viewer. The hint can be used to modify the Mirador viewer layout (in the default mirador configuration thumbnail navigation panel is added to the right).At some point in recent releases this stopped working and the "multi" parameter is never added, probably because switchMap is unsubscribing before the count is incremented in the inner observable.
Instructions for Reviewers
List of changes in this PR:
If you compile the frontend in production and view an IIIF-enabled item with more than one image you should see the multi parameter in the iframe URL and see a right navigation thumbnail menu in the viewer.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.