Prevent noisy Pulse orphan terminals

Launch Agent Pulse with exec in spawned terminals, close stale Terminal zsh windows from prior Pulse runs, preserve explicit scan roots, and suppress startup notification bells from historical alerts.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: Gregg Cochran

agent_pulse.py

@@ -3286,13 +3286,15 @@ class AgentPulseApp(App):
     _prev_error_rate_high: bool = False
     _alerted_milestones: set = None
     _alerted_commanders: set = None
+    _alerts_ready: bool = False
 
     def __init__(self) -> None:
         super().__init__()
         self.store = PulseStore()
         self.engine = MetricsEngine(self.store)
         self._alerted_milestones = set()
         self._alerted_commanders = set()
+        self._alerts_ready = False
 
     def compose(self) -> ComposeResult:
         yield Vertical(
@@ -3438,17 +3440,18 @@ def _poll(self) -> None:
         if self._paused:
             return
         m = self.engine.poll()
+        suppress_alerts = not self._alerts_ready
 
         # Feature 5: Alert on new agent launches
-        if self._prev_spawned > 0 and m.spawned_all_time > self._prev_spawned:
+        if not suppress_alerts and self._prev_spawned > 0 and m.spawned_all_time > self._prev_spawned:
             diff = m.spawned_all_time - self._prev_spawned
             if m.recent_events:
                 latest_type = m.recent_events[0][1]
                 self.notify(f"⚡ New {latest_type} agent launched", timeout=4)
 
         # Feature 5: Error rate alert
         error_high = m.error_count_24h > 3
-        if error_high and not self._prev_error_rate_high:
+        if not suppress_alerts and error_high and not self._prev_error_rate_high:
             self.notify("🔴 Error rate elevated", severity="error", timeout=6)
         self._prev_error_rate_high = error_high
 
@@ -3460,16 +3463,18 @@ def _poll(self) -> None:
             if key in self._alerted_commanders:
                 continue
             self._alerted_commanders.add(key)
-            self.notify(f"🛑 {alert.get('message', 'Commander died before completing')}", severity="error", timeout=10)
+            if not suppress_alerts:
+                self.notify(f"🛑 {alert.get('message', 'Commander died before completing')}", severity="error", timeout=10)
 
         # Feature 5: Milestones
         for milestone in (10, 50, 100, 500, 1000):
             if m.spawned_all_time >= milestone and milestone not in self._alerted_milestones:
                 self._alerted_milestones.add(milestone)
-                if self._prev_spawned > 0:  # don't alert on first load
+                if not suppress_alerts and self._prev_spawned > 0:
                     self.notify(f"🎉 Milestone: {milestone} agents!", timeout=8)
 
         self._prev_spawned = m.spawned_all_time
+        self._alerts_ready = True
 
         # Update all widgets
         self.logo.metrics = m

start.sh

@@ -98,7 +98,20 @@ if [ "$MODE" = "here" ]; then
 fi
 
 # --- Otherwise, spawn in a new window/pane of the user's terminal emulator ---
-CMD="export AGENT_PULSE_SPAWNED=1; cd '$SCRIPT_DIR' && '$VENV/bin/python' '$SCRIPT_DIR/agent_pulse.py' ${PASSTHROUGH_ARGS[*]}"
+shell_quote() {
+    printf "%q" "$1"
+}
+
+QUOTED_ARGS=""
+for arg in "${PASSTHROUGH_ARGS[@]}"; do
+    QUOTED_ARGS+=" $(shell_quote "$arg")"
+done
+
+CMD="export AGENT_PULSE_SPAWNED=1"
+if [ -n "${AGENT_PULSE_SCAN_ROOTS:-}" ]; then
+    CMD+="; export AGENT_PULSE_SCAN_ROOTS=$(shell_quote "$AGENT_PULSE_SCAN_ROOTS")"
+fi
+CMD+="; cd $(shell_quote "$SCRIPT_DIR") && exec $(shell_quote "$VENV/bin/python") $(shell_quote "$SCRIPT_DIR/agent_pulse.py")${QUOTED_ARGS}"
 
 # tmux — open a new window in the current session
 if [ -n "$TMUX" ]; then
@@ -172,6 +185,11 @@ case "$TERM_APP" in
         osascript -e "
             tell application \"Terminal\"
                 activate
+                repeat with w in windows
+                    if (name of w) contains \"copilot-cli-agent-pulse\" and (name of w) contains \"-zsh\" then
+                        close w saving no
+                    end if
+                end repeat
                 do script \"$CMD\"
             end tell" &>/dev/null
         echo "⚡ Agent Pulse launched in a new Terminal window."
@@ -201,6 +219,11 @@ case "$TERM_APP" in
             osascript -e "
                 tell application \"Terminal\"
                     activate
+                    repeat with w in windows
+                        if (name of w) contains \"copilot-cli-agent-pulse\" and (name of w) contains \"-zsh\" then
+                            close w saving no
+                        end if
+                    end repeat
                     do script \"$CMD\"
                 end tell" &>/dev/null
             echo "⚡ Agent Pulse launched in a new Terminal window."