fix: add explicit setuptools package discovery for Homebrew install#5
Open
RobertBolender wants to merge 2 commits intoDUBSOpenHub:mainfrom
Open
fix: add explicit setuptools package discovery for Homebrew install#5RobertBolender wants to merge 2 commits intoDUBSOpenHub:mainfrom
RobertBolender wants to merge 2 commits intoDUBSOpenHub:mainfrom
Conversation
Setuptools' automatic package discovery finds non-Python directories (site/, assets/, Formula/, experimental/) in the repo root and refuses to build, causing 'Getting requirements to build wheel' errors during `brew install agent-pulse`. Explicitly declare agent_pulse as the sole py-module so setuptools skips auto-discovery. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CSS_PATH fails when installed as a py_module since the .tcss file isn't copied to site-packages. Read the CSS inline via Path(__file__) with a graceful fallback when the file is absent. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
brew install agent-pulsefails with:Setuptools' automatic package discovery finds non-Python directories in the repo root and refuses to build.
Fix
Add an explicit
[tool.setuptools]section topyproject.tomldeclaringagent_pulseas the sole module:This tells setuptools exactly what to include, skipping auto-discovery entirely.
Testing
brew installfailure locallybrew installsucceeds (🍺)brew test agent-pulsepasses (--helpand--exportassertions)pip install .in a fresh venv also succeeds