Minor edits to pytest no ruff

Author: emmuhamm

tests/logging/test_handlers.py

@@ -71,7 +71,7 @@
 @pytest.fixture
 def clean_logger():
     """Provide a clean logger with no handlers or filters."""
-    logger = logging.getLogger("test_logger_" + str(time.time()))
+    logger = logging.getLogger("test_logger_handlers")
     logger.handlers = []
     logger.filters = []
     logger.setLevel(logging.DEBUG)
@@ -100,7 +100,7 @@ def ers_log_record():
         name="test.module",
         level=logging.ERROR,
         pathname="/path/to/test.py",
-        lineno=42,
+        lineno=67,
         msg="ERS message",
         args=(),
         exc_info=None,
@@ -116,7 +116,7 @@ def mock_ers_handlers():
     for level_var in level_to_ers_var.values():
         conf = ERSPyLogHandlerConf(
             handlers=[HandlerType.Throttle, HandlerType.Protobufstream],
-            protobufconf=ProtobufConf(url="test.kafka.com", port=9092),
+            protobufconf=ProtobufConf(url="monkafka.cern.ch", port=30092),
         )
         handlers_config[level_var] = conf
     return handlers_config
@@ -160,38 +160,14 @@ def test_ers_path_valid_configuration(self, ers_log_record, mock_ers_handlers):
 
         assert allowed == [HandlerType.Throttle, HandlerType.Protobufstream]
 
-    def test_ers_path_missing_ers_handlers_attribute(self, ers_log_record):
-        """Test get_allowed() returns None when ERS record lacks ers_handlers."""
-        # ers_log_record has stream=ERS but no ers_handlers attribute
-        filter_obj = BaseHandlerFilter()
-
-        allowed = filter_obj.get_allowed(ers_log_record)
-
-        assert allowed is None
-
     def test_ers_path_no_matching_level_variable(self, ers_log_record, mock_ers_handlers):
         """Test get_allowed() returns None when log level has no ERS mapping."""
-        # Set a log level that might not have an ERS equivalent
+        # Set a log level that does not have an ERS equivalent
         ers_log_record.levelno = 25  # Between INFO and WARNING
         ers_log_record.ers_handlers = mock_ers_handlers
         filter_obj = BaseHandlerFilter()
 
         allowed = filter_obj.get_allowed(ers_log_record)
-
-        # Level 25 likely won't map to any ERS variable, so should return None
-        # or might map to something - let's handle both cases
-        if 25 not in level_to_ers_var:
-            assert allowed is None
-
-    def test_ers_path_missing_handler_conf_for_level(self, ers_log_record):
-        """Test get_allowed() returns None when handler conf missing for level."""
-        ers_log_record.levelno = logging.DEBUG  # Low level
-        # Provide partial ers_handlers config missing the DEBUG entry
-        ers_log_record.ers_handlers = {}
-        filter_obj = BaseHandlerFilter()
-
-        allowed = filter_obj.get_allowed(ers_log_record)
-
         assert allowed is None
 
 
@@ -382,20 +358,6 @@ def test_timestamp_formatting(self):
         assert formatted.count("-") == 2  # Two dashes for date
         assert formatted.count(":") == 2  # Two colons for time
 
-    def test_report_suppression_not_called_when_counter_zero(self, log_record):
-        """Test that _report_suppression returns early if suppressed_counter is 0."""
-        filter_obj = ThrottleFilter()
-        issue_record = IssueRecord()
-        issue_record.suppressed_counter = 0
-
-        with patch.object(filter_obj, "_report_suppression") as mock_report:
-            filter_obj._report_suppression(issue_record, log_record)
-
-            # Should return early without doing anything
-            # (We can't easily test this without mocking, but the logic is clear)
-            # Just verify the method completes without error
-            assert True
-
     def test_different_issues_tracked_separately(self, log_record):
         """Test that different file:line combinations track state separately."""
         filter_obj = ThrottleFilter(initial_threshold=2, time_limit=10)