PR for ProtoDUNEBSMWindow TAMaker as a class in daqsystemtests#324
Open
CiaranH1997 wants to merge 9 commits into
Open
PR for ProtoDUNEBSMWindow TAMaker as a class in daqsystemtests#324CiaranH1997 wants to merge 9 commits into
CiaranH1997 wants to merge 9 commits into
Conversation
… updated parameters for new model.
Merge branch 'develop' of https://github.com/DUNE-DAQ/daqsystemtest into feature/bsm_window_v5_4_3
commits to this branch
MRiganSUSX
requested changes
Jun 23, 2026
MRiganSUSX
left a comment
Contributor
There was a problem hiding this comment.
Thanks @CiaranH1997,
Few changes are suggested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If full description and testing details are included on a parent issue, please link to that here.
See issue # for details
Otherwise, please include a summary of the change and which issue is fixed (if any).
Include relevant motivation and context, including a target environment and dunedaq version if known.
Also list any dependencies that are required for this change.
Addresses issue #
TAMakerProtoDUNEBSMWindowAlgorithm is added to modulesconf.data.xml as an additional class with a sensible set of default parameters for this TAMaker. All other parameters kept at their default value. No other changes.
Please also include instructions for how a reviewer can test your changes.
Type of change
Testing checklist
dbt-build --unittest)pytest -s minimal_system_quick_test.py)dunedaq_integtest_bundle.sh)python -m pytest)pre-commit run --all-files)Comments here on the testing
Further checks
dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)(Indicate issue here: # (issue))