Modified integtests to make use of new utility functions for setting trigger config params#325
Modified integtests to make use of new utility functions for setting trigger config params#325bieryAtFnal wants to merge 5 commits into
Conversation
…adout window parameters and start making use of common functions to set those params.
MRiganSUSX
left a comment
MRiganSUSX
left a comment
There was a problem hiding this comment.
Few small comments here
| utility_functions.set_RTCM_trigger_params(coincidence_bitword_conf, trigger_rate=40, | ||
| readout_window_backshift_ticks=0, readout_window_before_ticks=62500, | ||
| readout_window_after_ticks=62500) | ||
| utility_functions.set_fake_hsi_trigger_params(coincidence_bitword_conf, trigger_rate=30, | ||
| readout_window_before_ticks=62500, | ||
| readout_window_after_ticks=62500) |
There was a problem hiding this comment.
The 62500-tick readout window for kRandom triggers in coincidence_bitword_conf is now set only on RandomTCMakerConf via set_RTCM_trigger_params. The TCReadoutMap entry def-random-readout — which exists in the template XML — is left at its defaults of 1000/1001 ticks. This is safe today because def-random-readout is not currently referenced in the MLT tc_readout_map relation. But if it ever is added there, TCReadoutMap supersedes, and the test's readout window would silently collapse from 62500 to 1000 ticks.
TLDR, this is one of those places where things work atm, but are relying on assumptions and choices made in the default base config but can break.
(not sure what to do about that, I'm just thinking out loud here)
There was a problem hiding this comment.
Yes. There are other integtests that have this same feature, such as the long_window_readout_test. As you say, if something in the underlying configuration or code changes, then the tests will need to change also.
#325 and DUNE-DAQ/interationtest#161
3 participants
Description
These changes make use of the changes made in the
integrationtestrepo to provide utility functions that set various trigger parameters for integration tests (DUNE-DAQ/integrationtest#161).There are instructions for testing these changes in DUNE-DAQ/integrationtest#161, and these changes need to be tested and merged together the with changes in the
integrationtestrepo.Type of change
Testing checklist
dunedaq_integtest_bundle.sh)