Modified the bundle script and its helper scripts to include integtests from python-only packages#326
Open
bieryAtFnal wants to merge 2 commits into
Open
Modified the bundle script and its helper scripts to include integtests from python-only packages#326bieryAtFnal wants to merge 2 commits into
bieryAtFnal wants to merge 2 commits into
Conversation
added 2 commits
June 24, 2026 08:58
…ython-only packages with integtests.
Contributor
|
I checked the given commands and they work as advertised as described in the above script. One issue I bumped into, however - the line: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Now that we have integration tests from Python packages installed in the
.venvdirectory of software areas, we can proceed to include them in the global bundle script and its helper scripts:dunedaq_integtest_bundle.shlist_available_integtests.shlist_repos_with_integtests.shThe changes in this Pull Request attempt to do that.
Two notes:
pythoncodesubdirectory. (Typically, all Python packages are installed in the.venvsubdirectory of a local software area, so the presence of a package in that area can't be used to determine "local" vs. not-local.)-p no:cacheproviderqualifier to thepytestcommand when running integtests from Python packages that are not installed in a write-able location on disk. The reason for this is twofold: there are discussions about how to avoid needing to specify that qualifier, so we will let that discussion proceed. And in the short term, I expect that it will be rather rare for someone to run integtests from Python packages without having a local software area.Here are suggested steps for testing these changes:
Type of change
Testing checklist
dunedaq_integtest_bundle.sh)Further checks