Skip to content

Commit 0f9e56d

Browse files
authored
Merge pull request #208 from DUNE-DAQ/feature/extra_stop_commands
Feature/extra stop commands
2 parents 4f6a1a7 + 360223a commit 0f9e56d

10 files changed

Lines changed: 31 additions & 31 deletions

integtest/3ru_1df_multirun_test.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -71,10 +71,10 @@
7171

7272
# The commands to run in nanorc, as a list
7373
if sufficient_resources_on_this_computer:
74-
nanorc_command_list="integtest-partition boot init conf".split()
75-
nanorc_command_list+="start --resume-wait 1 101 wait ".split() + [str(run_duration)] + "stop wait 2".split()
76-
nanorc_command_list+="start --resume-wait 2 102 wait ".split() + [str(run_duration)] + "stop --stop-wait 1 wait 2".split()
77-
nanorc_command_list+="start 103 wait ".split() + [str(run_duration)] + "stop --stop-wait 2 wait 2".split()
74+
nanorc_command_list="integtest-partition boot conf".split()
75+
nanorc_command_list+="start_run --wait 1 101 wait ".split() + [str(run_duration)] + "stop_run wait 2".split()
76+
nanorc_command_list+="start_run --wait 2 102 wait ".split() + [str(run_duration)] + "stop_run --wait 1 wait 2".split()
77+
nanorc_command_list+="start_run 103 wait ".split() + [str(run_duration)] + "stop_run --wait 2 wait 2".split()
7878
nanorc_command_list+="scrap terminate".split()
7979
else:
8080
nanorc_command_list=["boot", "terminate"]

integtest/3ru_3df_multirun_test.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,10 @@
5151
"DQM_System": confgen_arguments_base+["--enable-dqm"],
5252
}
5353
# The commands to run in nanorc, as a list
54-
nanorc_command_list="integtest-partition boot init conf".split()
55-
nanorc_command_list+="start --resume-wait 1 101 wait ".split() + [str(run_duration)] + "stop wait 2".split()
56-
nanorc_command_list+="start --resume-wait 2 102 wait ".split() + [str(run_duration)] + "stop --stop-wait 1 wait 2".split()
57-
nanorc_command_list+="start 103 wait ".split() + [str(run_duration)] + "stop --stop-wait 2 wait 2".split()
54+
nanorc_command_list="integtest-partition boot conf".split()
55+
nanorc_command_list+="start 101 enable_triggers wait ".split() + [str(run_duration)] + "stop_run wait 2".split()
56+
nanorc_command_list+="start 102 wait 1 enable_triggers wait ".split() + [str(run_duration)] + "disable_triggers wait 1 stop_run".split()
57+
nanorc_command_list+="start_run 103 wait ".split() + [str(run_duration)] + "disable_triggers wait 1 drain_dataflow wait 1 stop_trigger_sources wait 1 stop wait 2".split()
5858
nanorc_command_list+="scrap terminate".split()
5959

6060
# The tests themselves

integtest/command_order_test.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
["integtest-partition", "conf"],
2525
["integtest-partition", "start", "100"],
2626
["integtest-partition", "resume"],
27-
["integtest-partition", "pause"],
27+
["integtest-partition", "disable_triggers"],
2828
["integtest-partition", "stop"],
2929
["integtest-partition", "scrap"],
3030

@@ -33,7 +33,7 @@
3333
"integtest-partition boot conf".split(),
3434
"integtest-partition boot start 101".split(),
3535
"integtest-partition boot resume".split(),
36-
"integtest-partition boot pause".split(),
36+
"integtest-partition boot disable_triggers".split(),
3737
"integtest-partition boot stop".split(),
3838
"integtest-partition boot scrap".split(),
3939

@@ -42,7 +42,7 @@
4242
"integtest-partition boot init init".split(),
4343
"integtest-partition boot init start 102".split(),
4444
"integtest-partition boot init resume".split(),
45-
"integtest-partition boot init pause".split(),
45+
"integtest-partition boot init disable_triggers".split(),
4646
"integtest-partition boot init stop".split(),
4747
"integtest-partition boot init scrap".split(),
4848

@@ -51,10 +51,10 @@
5151
"integtest-partition boot init conf init".split(),
5252
"integtest-partition boot init conf conf".split(),
5353
"integtest-partition boot init conf resume".split(),
54-
"integtest-partition boot init conf pause".split(),
54+
"integtest-partition boot init conf disable_triggers".split(),
5555
"integtest-partition boot init conf stop".split(),
5656

57-
# Only resume pause stop after start
57+
# Only resume disable_triggers stop after start
5858
"integtest-partition boot init conf start 103 boot".split(),
5959
"integtest-partition boot init conf start 104 init".split(),
6060
"integtest-partition boot init conf start 105 conf".split(),
@@ -66,15 +66,15 @@
6666
"integtest-partition boot init conf start 109 stop init".split(),
6767
"integtest-partition boot init conf start 110 stop conf".split(),
6868
"integtest-partition boot init conf start 111 stop resume".split(),
69-
"integtest-partition boot init conf start 112 stop pause".split(),
69+
"integtest-partition boot init conf start 112 stop disable_triggers".split(),
7070
"integtest-partition boot init conf start 113 stop stop".split(),
7171

7272
# After scrap is same as init
7373
"integtest-partition boot init conf start 114 stop scrap boot".split(),
7474
"integtest-partition boot init conf start 115 stop scrap init".split(),
7575
"integtest-partition boot init conf start 116 stop scrap start 121".split(),
7676
"integtest-partition boot init conf start 117 stop scrap resume".split(),
77-
"integtest-partition boot init conf start 118 stop scrap pause".split(),
77+
"integtest-partition boot init conf start 118 stop scrap disable_triggers".split(),
7878
"integtest-partition boot init conf start 119 stop scrap stop".split(),
7979
"integtest-partition boot init conf start 120 stop scrap scrap".split(),
8080

integtest/disabled_output_test.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,11 @@
4343
confgen_arguments={"WIB1_System": confgen_arguments_base,
4444
"Software_TPG_System": confgen_arguments_base+["--enable-software-tpg"]}
4545
# The commands to run in nanorc, as a list
46-
nanorc_command_list="integtest-partition boot init conf".split()
47-
nanorc_command_list+="start --disable-data-storage 101 wait ".split() + [str(run_duration)] + "stop --stop-wait 2 wait 2".split()
48-
nanorc_command_list+="start 102 wait ".split() + [str(run_duration)] + "stop --stop-wait 2 wait 2".split()
49-
nanorc_command_list+="start --disable-data-storage 103 wait ".split() + [str(run_duration)] + "pause wait 2 stop wait 2".split()
50-
nanorc_command_list+="start 104 wait ".split() + [str(run_duration)] + "pause wait 2 stop wait 2".split()
46+
nanorc_command_list="integtest-partition boot conf".split()
47+
nanorc_command_list+="start_run --disable-data-storage 101 wait ".split() + [str(run_duration)] + "stop_run --wait 2 wait 2".split()
48+
nanorc_command_list+="start_run 102 wait ".split() + [str(run_duration)] + "stop_run --wait 2 wait 2".split()
49+
nanorc_command_list+="start_run --disable-data-storage 103 wait ".split() + [str(run_duration)] + "disable_triggers wait 2 stop_run wait 2".split()
50+
nanorc_command_list+="start_run 104 wait ".split() + [str(run_duration)] + "disable_triggers wait 2 stop_run wait 2".split()
5151
nanorc_command_list+="scrap terminate".split()
5252

5353
# The tests themselves

integtest/fake_data_producer_test.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,10 @@
3737
# The commands to run in nanorc, as a list
3838
# (the first run [#100] is included to warm up the DAQ processes and avoid warnings and errors caused by
3939
# startup sluggishness seen on slower test computers)
40-
nanorc_command_list="integtest-partition boot init conf".split()
41-
nanorc_command_list+="start 101 wait ".split() + [str(run_duration)] + "stop --stop-wait 2 wait 2".split()
42-
nanorc_command_list+="start --resume-wait 1 102 wait ".split() + [str(run_duration)] + "stop wait 2".split()
43-
nanorc_command_list+="start --resume-wait 2 103 wait ".split() + [str(run_duration)] + "stop --stop-wait 1 wait 2".split()
40+
nanorc_command_list="integtest-partition boot conf".split()
41+
nanorc_command_list+="start_run 101 wait ".split() + [str(run_duration)] + "stop_run --wait 2 wait 2".split()
42+
nanorc_command_list+="start_run --wait 1 102 wait ".split() + [str(run_duration)] + "stop_run wait 2".split()
43+
nanorc_command_list+="start_run --wait 2 103 wait ".split() + [str(run_duration)] + "stop_run --wait 1 wait 2".split()
4444
nanorc_command_list+="scrap terminate".split()
4545

4646
# The tests themselves

integtest/long_window_readout_test.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,9 @@
4747
"With_TR_Splitting": confgen_arguments_base+["--max-trigger-record-window", str(trigger_record_max_window)],
4848
}
4949
# The commands to run in nanorc, as a list
50-
nanorc_command_list="integtest-partition boot init conf".split()
51-
nanorc_command_list+="start --resume-wait 15 101 wait ".split() + [str(run_duration)] + "stop --stop-wait 2 wait 2".split()
52-
nanorc_command_list+="start --resume-wait 15 102 wait ".split() + [str(run_duration)] + "stop wait 2".split()
50+
nanorc_command_list="integtest-partition boot conf".split()
51+
nanorc_command_list+="start_run --wait 15 101 wait ".split() + [str(run_duration)] + "stop_run --wait 2 wait 2".split()
52+
nanorc_command_list+="start 102 wait 15 enable_triggers wait ".split() + [str(run_duration)] + "stop_run wait 2".split()
5353
nanorc_command_list+="scrap terminate".split()
5454

5555
# The tests themselves

integtest/minimal_system_quick_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
# output directory (the test framework handles that)
3232
confgen_arguments=[ "-d", "./frames.bin", "-o", ".", "-s", "10", "-n", str(number_of_data_producers), "-b", "1000", "-a", "1000", "--host-ru", "localhost", "--op-env", "integtest"]
3333
# The commands to run in nanorc, as a list
34-
nanorc_command_list="integtest-partition boot init conf start 101 wait 1 resume wait ".split() + [str(run_duration)] + "pause wait 2 stop wait 2 scrap terminate".split()
34+
nanorc_command_list="integtest-partition boot conf start 101 wait 1 enable_triggers wait ".split() + [str(run_duration)] + "disable_triggers wait 2 stop_run wait 2 scrap terminate".split()
3535

3636
# The tests themselves
3737

integtest/multi_output_file_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
confgen_arguments={"WIB1_System": confgen_arguments_base,
4545
"Software_TPG_System": confgen_arguments_base+["--enable-software-tpg", "-c", str(3*number_of_data_producers*number_of_readout_apps)]}
4646
# The commands to run in nanorc, as a list
47-
nanorc_command_list="integtest-partition boot init conf start 101 resume wait 180 pause wait 2 stop wait 21 start 102 resume wait 120 pause wait 2 stop wait 21 scrap terminate".split()
47+
nanorc_command_list="integtest-partition boot conf start_run 101 wait 180 disable_triggers wait 2 stop_run wait 21 start_run 102 wait 120 disable_triggers wait 2 stop_run wait 21 scrap terminate".split()
4848

4949
# The tests themselves
5050

integtest/readout_type_scan.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@
6060
"PDS_(list)_System": confgen_arguments_base+["--frontend-type", "pds_list"],
6161
"PDS_(queue)_System": confgen_arguments_base+["--frontend-type", "pds_queue"]}
6262
# The commands to run in nanorc, as a list
63-
nanorc_command_list="integtest-partition boot init conf start 101 wait 1 resume wait ".split() + [str(run_duration)] + "pause wait 2 stop wait 2 scrap terminate".split()
63+
nanorc_command_list="integtest-partition boot conf start 101 wait 1 enable_triggers wait ".split() + [str(run_duration)] + "disable_triggers wait 2 stop_run wait 2 scrap terminate".split()
6464

6565
# The tests themselves
6666

plugins/DataFlowOrchestrator.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ DataFlowOrchestrator::DataFlowOrchestrator(const std::string& name)
5252
{
5353
register_command("conf", &DataFlowOrchestrator::do_conf);
5454
register_command("start", &DataFlowOrchestrator::do_start);
55-
register_command("stop", &DataFlowOrchestrator::do_stop);
55+
register_command("drain_dataflow", &DataFlowOrchestrator::do_stop);
5656
register_command("scrap", &DataFlowOrchestrator::do_scrap);
5757
}
5858

0 commit comments

Comments
 (0)