Skip to content

Remove broadcast code from drunc#945

Merged
PawelPlesniak merged 10 commits into
developfrom
jamesturner246/rm_broadcast
Jun 18, 2026
Merged

Remove broadcast code from drunc#945
PawelPlesniak merged 10 commits into
developfrom
jamesturner246/rm_broadcast

Conversation

@jamesturner246

@jamesturner246 jamesturner246 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes #944.

Remove all code relating to broadcasting from drunc.

Type of change

  • New feature / enhancement
  • Optimization
  • Bug fix
  • Breaking change
  • Documentation

List of required branches from other repositories

Relevant PR for druncschema changes:

DUNE-DAQ/druncschema#88

Change log

broadcast in PM and controller, and deleted the drunc.broadcast subpackage.

Suggested manual testing checklist

Usual standard checks.

Developer checklist

Prior to marking this as "Ready for Review"

Tests ran on: WHAT HOSTNAME from release RELEASE_NAME

Unit tests - some tests can't be ran on the CI. This is documented. If this PR checks a feature that can't be tested with CI, this has been marked appropriately.

Integration tests - the daqsystemtest_integtest_bundle requires a lot of resources, and connections to the EHN1 infrastructure. Check the cross referenced list if you can't run these. The developer needs to run at least the .

  • Unit tests (pytest --marker) passed
    • With relevant marker
    • Without marker
  • Integration tests passed
    • Only daqsystemtest_integtest_bundle.sh -k minimal_system_quick_test.py
    • Full daqsystemtest_integtest_bundle.sh
  • Testing skipped as there are no core code changes in this PR, this only relates to documentation/CI workflows
  • Drunc integration tests pass (./scripts/drunc_integtest_bundle.sh)

Final checklist prior to marking this as "Ready for Review"

  • Code is clearly commented.
  • New unit tests have been added, or is documented in # ISSUE NUMBER
  • A suitable reviewer has been chosen from this list.

Reviewer checklist

  • This branch has been rebased with develop prior to testing.
  • Suggested manual tests show changes.
  • CI workflows fails documented (if present)
  • Integration tests passed (on either np0x or IC HEP clusters)
    • Use the following guidelines to determine which of the integration tests you need to run
      • You do not need to run any integration tests if
        • Code changes are not associated with src/
        • PR changes only affect docstrings
        • In this case, be sure to validate any suggested manual testing.
      • Run only the minimum integration test as daqsystemtest_integtest_bundle.sh -k minimal_system_quick_test.py if
        • PR changes only affect a few log entries
        • PR changes are small, and do not have a large impact on the workflow (use carefully)
      • Otherwise run the full integration test bundle as daqsystemtest_integtest_bundle.sh
    • What to do if the integration tests fail?
      • Only concern yourself if failures related to drunc are in the log files
      • If non-drunc failure appears:
        • Validate failure in fresh working area
        • Contact Pawel if unsure
  • If you have ran the full integration test bundle, leave a comment on the PR stating
    • Which host the integration tests have ran on
    • [Optional] A copy of the test summary
  • Drunc integration tests pass (scripts/drunc_integtest_bundle.sh)

Once the above boxes are checked, the PR(s) can be merged following the steps below.

Prior to merging

Choose one of the following an complete all substeps
  • Changes only affect the Run Control, are in a single repository, and do not affect the end user.
    • Changes are documented in docstrings and code comments
    • Wiki has been updated if architectural or endpoint changes
  • Otherwise
    • Workflow changes demonstrated in the Change Log (if necessary)
    • Wiki has been updated (if necessary)
    • #dunedaq-integration Slack channel notified (see below)

Once completed, the reviewer can merge the PR.

Notification message for a Slack channel

Note - this should be to #dunedaq-integration for general workflow that isn't during a release candidate period, and to #daq-release-prep otherwise.

For an single merge that changes the user workflow

The CCM WG has an isolated PR ready to merge that affects user workflows. The PR is:

_URL_

I will leave time for any comments, otherwise will merge these at the end of the work day _Insert your time zone_.

For co-ordinated merge

The CCM WG has a set of co-ordinated merges ready to merge. The PRs are:

_URL_

_URL_


I will leave time for any comments, otherwise will merge these at the end of the day.

@Aurashk

Aurashk commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

@jamesturner246 I've looked at the process manager parts and the changes look good. I'm very happy to see those decorators go!

Only thing to flag is that this may have merge conflicts with the mypy stuff #936, not sure if there's much we can do to avoid that though

@PawelPlesniak

Copy link
Copy Markdown
Collaborator

Thank you James. I am running the integration tests at EHN1 now.

@PawelPlesniak

PawelPlesniak commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Integration tests pass on np04-srv-029 using NFD_DEV_260618_A9

+++++++++++++++++++++++++++++++++++++++++++++++++
++++++++++++++++++++ SUMMARY ++++++++++++++++++++
+++++++++++++++++++++++++++++++++++++++++++++++++

Thu Jun 18 11:50:33 AM CEST 2026
Log file is: /tmp/pytest-of-pplesnia/dunedaq_integtest_bundle_20260618111101.log

⮕ Running daqsystemtest/3ru_1df_multirun_test.py ⬅
======================== 6 passed ✅ in 241.34s (0:04:01) =========================
⮕ Running daqsystemtest/3ru_3df_multirun_test.py ⬅
======================== 6 passed ✅ in 241.45s (0:04:01) =========================
⮕ Running daqsystemtest/disabled_tpg_test.py ⬅
========================= 1 failed ❌, 2 passed ✅ in 54.24s =========================
⮕ Running daqsystemtest/example_system_test.py ⬅
======================== 12 passed ✅ in 227.84s (0:03:47) ========================
⮕ Running daqsystemtest/fake_data_producer_test.py ⬅
======================== 6 passed ✅ in 235.99s (0:03:55) =========================
⮕ Running daqsystemtest/long_window_readout_test.py ⬅
============================== 1 skipped 🟡 in 1.10s ==============================
⮕ Running daqsystemtest/minimal_system_quick_test.py ⬅
============================== 4 passed ✅ in 51.69s ==============================
⮕ Running daqsystemtest/readout_type_scan_test.py ⬅
======================== 33 passed ✅ in 579.96s (0:09:39) ========================
⮕ Running daqsystemtest/sample_ehn1_multihost_test.py ⬅
============================= 4 skipped 🟡 in 45.49s ==============================
⮕ Running daqsystemtest/small_footprint_quick_test.py ⬅
============================== 3 passed ✅ in 49.35s ==============================
⮕ Running daqsystemtest/tpg_state_collection_test.py ⬅
======================== 5 passed ✅ in 108.08s (0:01:48) =========================
⮕ Running daqsystemtest/tpreplay_test.py ⬅
======================== 6 passed ✅ in 123.56s (0:02:03) =========================
⮕ Running daqsystemtest/tpstream_writing_test.py ⬅
======================== 4 passed ✅ in 105.67s (0:01:45) =========================
⮕ Running daqsystemtest/trigger_bitwords_test.py ⬅
======================== 18 passed ✅ in 288.60s (0:04:48) ========================

Note - the above failure is associated with the data contents of one of the files, no further action needs to be taken

@PawelPlesniak

Copy link
Copy Markdown
Collaborator

Just validated a production run too, LGTM.

@PawelPlesniak PawelPlesniak merged commit fcf1c9b into develop Jun 18, 2026
5 checks passed
@PawelPlesniak PawelPlesniak deleted the jamesturner246/rm_broadcast branch June 18, 2026 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Medium/Large Impact Change]: remove broadcast code from drunc and druncschema

5 participants