Skip to content

Commit 08653ae

Browse files
committed
Change r_forceAmbient to a new-style cvar
1 parent 370f50b commit 08653ae

4 files changed

Lines changed: 16 additions & 16 deletions

File tree

src/engine/renderer/tr_bsp.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4124,10 +4124,10 @@ void R_LoadLightGrid( lump_t *l )
41244124
tmpDirected[ 2 ] = in->directed[ 2 ];
41254125
tmpDirected[ 3 ] = 255;
41264126

4127-
if ( tmpAmbient[0] < r_forceAmbient->value &&
4128-
tmpAmbient[1] < r_forceAmbient->value &&
4129-
tmpAmbient[2] < r_forceAmbient->value ) {
4130-
VectorSet( tmpAmbient, r_forceAmbient->value, r_forceAmbient->value, r_forceAmbient->value );
4127+
if ( tmpAmbient[0] < r_forceAmbient.Get() &&
4128+
tmpAmbient[1] < r_forceAmbient.Get() &&
4129+
tmpAmbient[2] < r_forceAmbient.Get() ) {
4130+
VectorSet( tmpAmbient, r_forceAmbient.Get(), r_forceAmbient.Get(), r_forceAmbient.Get() );
41314131
}
41324132

41334133
if ( tr.legacyOverBrightClamping )
@@ -4352,7 +4352,7 @@ void R_LoadEntities( lump_t *l, std::string &externalEntities )
43524352
// check for ambient color
43534353
else if ( !Q_stricmp( keyname, "_color" ) || !Q_stricmp( keyname, "ambientColor" ) )
43544354
{
4355-
if ( r_forceAmbient->value <= 0 ) {
4355+
if ( r_forceAmbient.Get() == 0 ) {
43564356
sscanf( value, "%f %f %f", &tr.ambientLight[0], &tr.ambientLight[1],
43574357
&tr.ambientLight[2] );
43584358

src/engine/renderer/tr_init.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,8 @@ Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
216216
cvar_t *r_wolfFog;
217217
cvar_t *r_noFog;
218218

219-
cvar_t *r_forceAmbient;
219+
Cvar::Range<Cvar::Cvar<float>> r_forceAmbient( "r_forceAmbient", "Minimal light amount in lightGrid", Cvar::NONE,
220+
0.125f, 0.0f, 0.3f );
220221
cvar_t *r_ambientScale;
221222
cvar_t *r_lightScale;
222223
cvar_t *r_debugSort;
@@ -1149,8 +1150,7 @@ ScreenshotCmd screenshotPNGRegistration("screenshotPNG", ssFormat_t::SSF_PNG, "p
11491150
r_wolfFog = Cvar_Get( "r_wolfFog", "1", CVAR_CHEAT );
11501151
r_noFog = Cvar_Get( "r_noFog", "0", CVAR_CHEAT );
11511152

1152-
r_forceAmbient = Cvar_Get( "r_forceAmbient", "0.125", CVAR_LATCH );
1153-
AssertCvarRange( r_forceAmbient, 0.0f, 0.3f, false );
1153+
Cvar::Latch( r_forceAmbient );
11541154

11551155
r_smp = Cvar_Get( "r_smp", "0", CVAR_LATCH );
11561156

src/engine/renderer/tr_light.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -248,13 +248,13 @@ int R_LightForPoint( vec3_t point, vec3_t ambientLight, vec3_t directedLight, ve
248248

249249
VectorNormalize( lightDir );
250250

251-
if ( ambientLight[ 0 ] < r_forceAmbient->value &&
252-
ambientLight[ 1 ] < r_forceAmbient->value &&
253-
ambientLight[ 2 ] < r_forceAmbient->value )
251+
if ( ambientLight[ 0 ] < r_forceAmbient.Get() &&
252+
ambientLight[ 1 ] < r_forceAmbient.Get() &&
253+
ambientLight[ 2 ] < r_forceAmbient.Get() )
254254
{
255-
ambientLight[ 0 ] = r_forceAmbient->value;
256-
ambientLight[ 1 ] = r_forceAmbient->value;
257-
ambientLight[ 2 ] = r_forceAmbient->value;
255+
ambientLight[ 0 ] = r_forceAmbient.Get();
256+
ambientLight[ 1 ] = r_forceAmbient.Get();
257+
ambientLight[ 2 ] = r_forceAmbient.Get();
258258
}
259259

260260
return true;

src/engine/renderer/tr_local.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2891,8 +2891,8 @@ enum class shaderProfilerRenderSubGroupsMode {
28912891

28922892
extern cvar_t *r_wolfFog;
28932893
extern cvar_t *r_noFog;
2894-
2895-
extern cvar_t *r_forceAmbient;
2894+
2895+
extern Cvar::Range<Cvar::Cvar<float>> r_forceAmbient;
28962896
extern cvar_t *r_ambientScale;
28972897
extern cvar_t *r_lightScale;
28982898

0 commit comments

Comments
 (0)