Skip to content

Commit 3bd5cca

Browse files
committed
Use srfGenerict_t::numTriangles instead of srfVBOMesh_t::numIndexes
NUKE the latter, since it's really just duplicating code.
1 parent 7f596b8 commit 3bd5cca

4 files changed

Lines changed: 8 additions & 11 deletions

File tree

src/engine/renderer/tr_bsp.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -788,7 +788,7 @@ static void FinishSkybox() {
788788
surface = ( srfVBOMesh_t* ) ri.Hunk_Alloc( sizeof( *surface ), ha_pref::h_low );
789789
surface->surfaceType = surfaceType_t::SF_VBO_MESH;
790790
surface->numVerts = 8;
791-
surface->numIndexes = 36;
791+
surface->numTriangles = 12;
792792
surface->firstIndex = 0;
793793

794794
vec3_t verts[ 8 ] {
@@ -813,7 +813,7 @@ static void FinishSkybox() {
813813
2, 7, 6, 2, 3, 7, // Right
814814
3, 4, 7, 3, 0, 4 }; // Back
815815

816-
surface->ibo = R_CreateStaticIBO( "skybox_IBO", indexes, surface->numIndexes );
816+
surface->ibo = R_CreateStaticIBO( "skybox_IBO", indexes, surface->numTriangles * 3 );
817817
skybox->surface = ( surfaceType_t* ) surface;
818818

819819
tr.skybox = skybox;
@@ -2946,7 +2946,7 @@ static void R_CreateWorldVBO()
29462946
*vboSurf = {};
29472947
vboSurf->surfaceType = surfaceType_t::SF_VBO_MESH;
29482948

2949-
vboSurf->numIndexes = surfIndexes;
2949+
vboSurf->numTriangles = surfIndexes / 3;
29502950
vboSurf->numVerts = surfVerts;
29512951
vboSurf->firstIndex = firstIndex;
29522952

src/engine/renderer/tr_local.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1779,9 +1779,6 @@ enum class ssaoMode {
17791779

17801780
struct srfVBOMesh_t : srfGeneric_t {
17811781
int lightmapNum; // FIXME get rid of this by merging all lightmaps at level load
1782-
1783-
// backEnd stats
1784-
int numIndexes;
17851782
};
17861783

17871784
struct srfVBOMD5Mesh_t

src/engine/renderer/tr_surface.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1371,7 +1371,7 @@ static void Tess_SurfaceVBOMesh( srfVBOMesh_t *srf )
13711371
{
13721372
GLIMP_LOGCOMMENT( "--- Tess_SurfaceVBOMesh ---" );
13731373

1374-
Tess_SurfaceVBO( srf->vbo, srf->ibo, srf->numIndexes, srf->firstIndex );
1374+
Tess_SurfaceVBO( srf->vbo, srf->ibo, srf->numTriangles * 3, srf->firstIndex );
13751375
}
13761376

13771377
/*

src/engine/renderer/tr_vbo.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -601,7 +601,7 @@ static void R_InitGenericVBOs() {
601601
surface = ( srfVBOMesh_t* ) ri.Hunk_Alloc( sizeof( *surface ), ha_pref::h_low );
602602
surface->surfaceType = surfaceType_t::SF_VBO_MESH;
603603
surface->numVerts = 4;
604-
surface->numIndexes = 6;
604+
surface->numTriangles = 2;
605605
surface->firstIndex = 0;
606606

607607
vec3_t verts[4] = {
@@ -628,7 +628,7 @@ static void R_InitGenericVBOs() {
628628

629629
glIndex_t indexes[6] = { 0, 2, 1, 0, 3, 2 }; // Front
630630

631-
surface->ibo = R_CreateStaticIBO( "genericQuad_IBO", indexes, surface->numIndexes );
631+
surface->ibo = R_CreateStaticIBO( "genericQuad_IBO", indexes, surface->numTriangles * 3 );
632632
genericQuad->surface = ( surfaceType_t* ) surface;
633633

634634
tr.genericQuad = genericQuad;
@@ -641,14 +641,14 @@ static void R_InitGenericVBOs() {
641641
srfVBOMesh_t* surface = ( srfVBOMesh_t* ) ri.Hunk_Alloc( sizeof( *surface ), ha_pref::h_low );
642642
surface->surfaceType = surfaceType_t::SF_VBO_MESH;
643643
surface->numVerts = 0;
644-
surface->numIndexes = 3;
644+
surface->numTriangles = 1;
645645
surface->firstIndex = 0;
646646

647647
surface->vbo = nullptr;
648648

649649
glIndex_t indexes[6] = { 0, 2, 1 }; // Front
650650

651-
surface->ibo = R_CreateStaticIBO( "genericTriangle_IBO", indexes, surface->numIndexes );
651+
surface->ibo = R_CreateStaticIBO( "genericTriangle_IBO", indexes, surface->numTriangles * 3 );
652652
genericTriangle->surface = ( surfaceType_t* ) surface;
653653

654654
tr.genericTriangle = genericTriangle;

0 commit comments

Comments
 (0)