glsl_restart: Stop segfaulting

Using git bisect, e497a08 introduces a
window where globalUBOProxy can be null after glsl_restart. Therefore,
also return early, if glboalUBOProxy is null. It will be instantiated
later.

Further, only initialize world shaders *AFTER* all shader storage has
been initiialized.

Author: DolceTriade

src/engine/renderer/tr_backend.cpp

@@ -3000,7 +3000,7 @@ static void RB_RenderPostProcess()
 
 static void SetFrameUniforms() {
 	// This can happen with glsl_restart/vid_restart in R_SyncRenderThread()
-	if ( !stagingBuffer.Active() ) {
+	if ( !stagingBuffer.Active() || globalUBOProxy == nullptr ) {
 		return;
 	}
 

src/engine/renderer/tr_shade.cpp

@@ -198,7 +198,7 @@ static void EnableAvailableFeatures()
 	glConfig.usingGeometryCache = glConfig.usingMaterialSystem && glConfig.geometryCacheAvailable;
 }
 
-// For shaders that require map data for compile-time values 
+// For shaders that require map data for compile-time values
 void GLSL_InitWorldShaders() {
 	// make sure the render thread is stopped
 	R_SyncRenderThread();
@@ -256,11 +256,6 @@ static void GLSL_InitGPUShadersOrError()
 		gl_depthReductionShader->MarkProgramForBuilding();
 	}
 
-	if ( tr.world ) // this only happens with /glsl_restart
-	{
-		GLSL_InitWorldShaders();
-	}
-
 	if ( glConfig.realtimeLighting )
 	{
 		gl_shaderManager.LoadShader( gl_depthtile1Shader );
@@ -344,7 +339,7 @@ static void GLSL_InitGPUShadersOrError()
 
 		gl_contrastShader->MarkProgramForBuilding();
 	}
-	
+
 	// portal process effect
 	gl_shaderManager.LoadShader( gl_portalShader );
 
@@ -397,6 +392,12 @@ static void GLSL_InitGPUShadersOrError()
 	gl_shaderManager.PostProcessGlobalUniforms();
 	gl_shaderManager.InitShaders();
 
+	// Init world shaders last so that everyhthing is already initialized.
+	if ( tr.world ) // this only happens with /glsl_restart
+	{
+		GLSL_InitWorldShaders();
+	}
+
 	if ( r_lazyShaders.Get() == 0 )
 	{
 		gl_shaderManager.BuildAll( false );
@@ -1481,7 +1482,7 @@ void Render_heatHaze( shaderStage_t *pStage )
 
 	// bind u_NormalMap
 	gl_heatHazeShader->SetUniform_NormalMapBindless(
-		GL_BindToTMU( 0, pStage->bundle[TB_NORMALMAP].image[0] ) 
+		GL_BindToTMU( 0, pStage->bundle[TB_NORMALMAP].image[0] )
 	);
 
 	if ( pStage->enableNormalMapping )
@@ -1497,7 +1498,7 @@ void Render_heatHaze( shaderStage_t *pStage )
 
 	// bind u_CurrentMap
 	gl_heatHazeShader->SetUniform_CurrentMapBindless(
-		GL_BindToTMU( 1, tr.currentRenderImage[backEnd.currentMainFBO] ) 
+		GL_BindToTMU( 1, tr.currentRenderImage[backEnd.currentMainFBO] )
 	);
 
 	gl_heatHazeShader->SetRequiredVertexPointers();
@@ -1507,7 +1508,7 @@ void Render_heatHaze( shaderStage_t *pStage )
 	// copy to foreground image
 	R_BindFBO( tr.mainFBO[ backEnd.currentMainFBO ] );
 	gl_heatHazeShader->SetUniform_CurrentMapBindless(
-		GL_BindToTMU( 1, tr.currentRenderImage[1 - backEnd.currentMainFBO] ) 
+		GL_BindToTMU( 1, tr.currentRenderImage[1 - backEnd.currentMainFBO] )
 	);
 	gl_heatHazeShader->SetUniform_DeformMagnitude( 0.0f );
 	Tess_DrawElements();