bikeshedding: make syntax coloring happier#1226
Merged
Conversation
illwieckz
force-pushed
the
illwieckz/pedantic-ifdef
branch
2 times, most recently
from
2db2cc5 to
fa58272
Compare
Member
Author
|
The exact same change as been discussed in Unvanquished/Unvanquished#3327 and accepted: It is already merged on game side, so we better merge it on engine side for consistency. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purely useless change, but the parenthesis pair being broken by some ifdef make unhappy the syntax coloring of vim and that annoys me every time I open this file. 😏️
I guess the compiler can optimize out the extra variable.