Skip to content

cmake: refactor game build configuration to reuse the same code in parent build or subproject build and mutualize code between vm type build#1555

Merged
illwieckz merged 1 commit intomasterfrom
illwieckz/daemongame/sync
Mar 17, 2025
Merged

cmake: refactor game build configuration to reuse the same code in parent build or subproject build and mutualize code between vm type build#1555
illwieckz merged 1 commit intomasterfrom
illwieckz/daemongame/sync

Conversation

@illwieckz
Copy link
Copy Markdown
Member

@illwieckz illwieckz commented Feb 14, 2025

Refactor game build configuration to reuse the same code in parent build or subproject build and mutualize code between vm type build.

Extracted from:

This one brings nothing new, it just refactors the code in a better way so it makes future changes easier.

Amont various things,

  • it makes building vm subproject independent from NaCl
  • it deduplicates and mutualises the code to avoid maintaining multiple copy-paste

…rent build or subproject build and mutualize code between vm type build
@illwieckz illwieckz force-pushed the illwieckz/daemongame/sync branch from 96eded5 to a815d6c Compare February 26, 2025 03:23
@illwieckz
Copy link
Copy Markdown
Member Author

@illwieckz illwieckz force-pushed the illwieckz/daemongame/sync branch from a815d6c to 4faf3a8 Compare March 11, 2025 14:23
@illwieckz
Copy link
Copy Markdown
Member Author

Now rebased.

@illwieckz illwieckz force-pushed the illwieckz/daemongame/sync branch from 4faf3a8 to 3c14462 Compare March 13, 2025 17:11
@slipher
Copy link
Copy Markdown
Member

slipher commented Mar 15, 2025

LGTM

@illwieckz illwieckz merged commit d76ea58 into master Mar 17, 2025
9 checks passed
@illwieckz illwieckz deleted the illwieckz/daemongame/sync branch March 17, 2025 14:56
illwieckz added a commit that referenced this pull request Mar 25, 2025
illwieckz added a commit that referenced this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants