Conversation
…rent build or subproject build and mutualize code between vm type build
slipher
reviewed
Feb 24, 2025
illwieckz
force-pushed
the
illwieckz/daemongame/sync
branch
from
96eded5 to
a815d6c
Compare
Member
Author
|
There is no need for game-side patch anymore (which is now closed): This PR is standalone. |
illwieckz
force-pushed
the
illwieckz/daemongame/sync
branch
from
a815d6c to
4faf3a8
Compare
Member
Author
|
Now rebased. |
illwieckz
force-pushed
the
illwieckz/daemongame/sync
branch
from
4faf3a8 to
3c14462
Compare
Member
|
LGTM |
illwieckz
added a commit
that referenced
this pull request
Mar 17, 2025
illwieckz
added a commit
that referenced
this pull request
Mar 17, 2025
illwieckz
added a commit
that referenced
this pull request
Mar 25, 2025
illwieckz
added a commit
that referenced
this pull request
Mar 25, 2025
illwieckz
added a commit
that referenced
this pull request
Mar 25, 2025
illwieckz
added a commit
that referenced
this pull request
Mar 25, 2025
illwieckz
added a commit
that referenced
this pull request
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor game build configuration to reuse the same code in parent build or subproject build and mutualize code between vm type build.
Extracted from:
This one brings nothing new, it just refactors the code in a better way so it makes future changes easier.
Amont various things,