Mac: don't vid_restart when toggling full-screen#1582
Merged
slipher merged 1 commit intoDaemonEngine:masterfrom Mar 8, 2025
Merged
Mac: don't vid_restart when toggling full-screen#1582slipher merged 1 commit intoDaemonEngine:masterfrom
slipher merged 1 commit intoDaemonEngine:masterfrom
Conversation
The keyboard shortcut (Command+F) for toggling fullscreen mode unnecessarily issued vid_restart. It works fine without that as can be seen by just setting the cvar r_fullscreen.
Member
Author
|
There's an ominous comment in SDL documentation: "Note that for some renderers, this function may trigger an SDL_RENDER_TARGETS_RESET event. Your application should be prepared to handle this event by reuploading textures!" But people say this doesn't happen for OpenGL contexts. Anyway, if there were a possible bug, you could already trigger it by setting the cvar directly. |
VReaperV
approved these changes
Mar 7, 2025
Contributor
VReaperV
left a comment
VReaperV
left a comment
There was a problem hiding this comment.
Not tested, but code LGTM.
DolceTriade
approved these changes
Mar 7, 2025
Member
|
It was likely a relic of some very old code. For example Tremulous GPP was issuing a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The keyboard shortcut (Command+F) for toggling fullscreen mode unnecessarily issued vid_restart. It works fine without that as can be seen by just setting the cvar r_fullscreen.