Don't print some network information on startup#1602
Merged
slipher merged 3 commits intoDaemonEngine:masterfrom Mar 18, 2025
Merged
Don't print some network information on startup#1602slipher merged 3 commits intoDaemonEngine:masterfrom
slipher merged 3 commits intoDaemonEngine:masterfrom
Conversation
On my machine I get 3 of these link-local addresses for each of IPv4 and IPv6. I think only 1 of each type will even work for LAN connections. So these logs seem to be of limited benefit to users since one who has enough knowledge to know which one to use would have known how to look it up anyway. Furthermore, this information can make people hesitate to post logs due to concerns that they contain sensitive information.
It was only provided in the client before. But in fact it is only relevant for server-side networking. Also migrate it to new-style command.
This is an easily overlooked bit of potentially personally identifying information. It may be the "computer's name" on personal machines. So don't log it by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't print the hostname and network addresses that may make people worry about posting logs with confidential information. Instead the
showipcommand can be used. Make the command available for all engines.Fixes Unvanquished/Unvanquished#1573.