client: make the error popup disableable#1605
Merged
Conversation
DolceTriade
reviewed
Mar 18, 2025
DolceTriade
approved these changes
Mar 18, 2025
slipher
reviewed
Mar 18, 2025
| #endif | ||
| #endif | ||
|
|
||
| static Cvar::Cvar<bool> client_errorPopup("client.errorPopup", "Enable the error popup window", Cvar::TEMPORARY, true); |
Member
There was a problem hiding this comment.
Remove TEMPORARY? TEMPORARY, like ARCHIVE, has little reason to be used now that cvar commands don't automatically archive things.
illwieckz
force-pushed
the
illwieckz/error-popup
branch
from
4943eeb to
1afcf02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the error popup disableable.
The error popup is very useful for end users, to let them know what happened when the engine has to stop in an unexpected way.
But such error popup turns testing into torture, requiring a manual action after every test run hits a fatal error, and requiring a direct input access to the test bed.
This adds a cvar named
client.errorPopupwhich is enabled by default. When disabled, the error popup is never displayed, letting the engine stop without requiring a manual intervention on the computer running the engine.