Skip to content

client: make the error popup disableable #1605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
illwieckz merged 1 commit into from
Mar 18, 2025
Merged

client: make the error popup disableable #1605

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/engine/client/ClientApplication.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ extern SDL_Window *window;
#endif
#endif

static Cvar::Cvar<bool> client_errorPopup("client.errorPopup", "Enable the error popup window", Cvar::NONE, true);

namespace Application {

class ClientApplication : public Application {
Expand Down Expand Up @@ -126,7 +128,7 @@ class ClientApplication : public Application {

void Shutdown(bool error, Str::StringRef message) override {
#if defined(_WIN32) || defined(BUILD_GRAPHICAL_CLIENT)
if (error) {
if (error && client_errorPopup.Get()) {
SDL_ShowSimpleMessageBox(SDL_MESSAGEBOX_ERROR, PRODUCT_NAME, message.c_str(), window);
}
#endif
Expand Down