cmake: make sure the dll game is built as module, not as static library#1607
Merged
cmake: make sure the dll game is built as module, not as static library#1607
Conversation
Member
Author
|
I merge this quickly because it fixes a regression breaking the build, and we better not merge anything between the breakage and the fix, to limit the impact on future bisects. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure the dll game is built as module, not as static library.
Fixup for:
This wasn't caught by the CI, but a bug in #1555 made the dll game being compiled to
cgame-native-dll.ainstead ofcgame-native-dll.so. Also, this hid another bug where CMake would overwriteCOMPILE_DEFINITIONSand then lose theBUILD_VM_IN_PROCESSdefinition.